Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update env reset interface #307

Merged
merged 14 commits into from
Apr 22, 2019
Merged

Update env reset interface #307

merged 14 commits into from
Apr 22, 2019

Conversation

kengz
Copy link
Owner

@kengz kengz commented Apr 21, 2019

Update env reset interface

  • update env.reset interface to be consistent with gym return: state. all logic perserved
  • methods involved:
    • env.reset
    • env.space_reset
    • env.space_step
    • env_space.reset
  • purge memory.base_update for simplicity and update memory.update to remain equivalent

Memory/Misc

  • move total_reward from memory into body, improve calculation and logging
  • remove onpolicy memory warn_size_once to simplify code since sample already checks for flushing
  • rename memory.true_size to memory.size
  • add reward_ma to body.df
  • purge debug2, debug3 logger methods

@kengz kengz merged commit 8e34a0f into v4-dev Apr 22, 2019
@kengz kengz deleted the env-reset branch April 22, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant