Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change a,r,s' interface to s,a,r,s' #305

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Change a,r,s' interface to s,a,r,s' #305

merged 1 commit into from
Apr 21, 2019

Conversation

kengz
Copy link
Owner

@kengz kengz commented Apr 21, 2019

Change interface to s,a,r,s'

  • change all the interface from action, reward, state to state, action, reward, next_state and propagate in all methods
  • this is a safe interface change without affecting logic. all changes are traceable and complete. Procedure: add new argument, rename old state to next_state.
  • this means the internal variable self.last_state of memory is no longer needed
  • changes done in:
    • control loop for singleton and space, which affects
    • agent.update, which affects
    • memory.update, which affects
    • memory.base_update and memory.add_experience

@kengz kengz changed the base branch from master to v4-dev April 21, 2019 05:35
@kengz kengz merged commit 8171a24 into v4-dev Apr 21, 2019
@kengz kengz deleted the sars branch April 21, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant