Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding vizdoom functionality (all credit to @joelouismarino) #222

Merged
merged 3 commits into from
Nov 3, 2018
Merged

Adding vizdoom functionality (all credit to @joelouismarino) #222

merged 3 commits into from
Nov 3, 2018

Conversation

mwcvitkovic
Copy link
Contributor

Feature / Fix

@kengz kengz requested review from lgraesser and kengz November 2, 2018 06:24
@kengz
Copy link
Owner

kengz commented Nov 2, 2018

Thanks for the PR! will review soon

kengz
kengz requested changes Nov 3, 2018
View reviewed changes
Copy link
Owner

@kengz kengz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thanks @joelouismarino.
I'll switch the merge to a staging branch first, run some quick tests, edit README, then carry the merge into master.

slm_lab/agent/algorithm/policy_util.py Show resolved Hide resolved
slm_lab/agent/memory/onpolicy.py Show resolved Hide resolved
slm_lab/agent/memory/onpolicy.py Show resolved Hide resolved
slm_lab/env/registration.py Show resolved Hide resolved
slm_lab/env/registration.py Show resolved Hide resolved
slm_lab/env/vizdoom/__init__.py Show resolved Hide resolved
slm_lab/env/vizdoom/vizdoom_env.py Show resolved Hide resolved
slm_lab/env/vizdoom/vizdoom_env.py Show resolved Hide resolved
slm_lab/env/vizdoom/vizdoom_env.py Show resolved Hide resolved
slm_lab/env/vizdoom/vizdoom_env.py Show resolved Hide resolved
@kengz kengz self-assigned this Nov 3, 2018
@kengz kengz changed the base branch from master to staging November 3, 2018 04:13
@kengz kengz merged commit 961fa0e into kengz:staging Nov 3, 2018
@kengz kengz mentioned this pull request Nov 3, 2018
Merged
kengz added a commit that referenced this pull request Nov 3, 2018
@kengz
Merge VizDoom, Image replays to master (#224)
03938c1 
* Adding vizdoom functionality (all credit to @joelouismarino) (#222)

* Adding vizdoom functionality (hat tip @joelouismarino)

* Typos

* Typo/bug

* add ImageReplay equivalent to memory

* finish single quote replacement, testing VizDoom next

* update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kengz kengz kengz approved these changes

@lgraesser lgraesser Awaiting requested review from lgraesser

Assignees

@kengz kengz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwcvitkovic @kengz