-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#32 Added checkstyle plugin to pom with default sun coding conventions. #38
Conversation
#32 Added checkstyle plugin to pom with default sun coding conventions.
Awesome! Thanks |
@kenglxn I guess you mean the svg creation. Maybe delay it for 2.1 and have some more testers before via snapshot releases. |
@atomfrede yes I did mean that. Very strange that the comment shows up here. I thought I added the comment to your fork.. |
Weird.. I added the comment here: atomfrede@6e9dbfd Seems like github is experiencing some issues with comments right now.. |
I have been too busy to get the 2.0 release.. shame on me :( This week for sure. |
Ah! It' a commit comment. Forgot about my open PR when I merged this into my master branch therefore SVG support became part of this PR already :( Maybe just remove |
I'd be fine with you just hiding it from the public API for 2.0, the we just expose it in 2.1 |
Great will create another PR later today. |
Just added checkstyle plugin and standard sun conventions file. Must be adapted to desired configuration (don't know if you've changed default IDEA formatting).