Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32 Added checkstyle plugin to pom with default sun coding conventions. #38

Merged
merged 3 commits into from
Oct 14, 2014

Conversation

atomfrede
Copy link
Contributor

Just added checkstyle plugin and standard sun conventions file. Must be adapted to desired configuration (don't know if you've changed default IDEA formatting).

kenglxn added a commit that referenced this pull request Oct 14, 2014
#32 Added checkstyle plugin to pom with default sun coding conventions.
@kenglxn kenglxn merged commit e475c86 into kenglxn:master Oct 14, 2014
@kenglxn
Copy link
Owner

kenglxn commented Oct 14, 2014

Awesome! Thanks

@atomfrede
Copy link
Contributor Author

@kenglxn I guess you mean the svg creation. Maybe delay it for 2.1 and have some more testers before via snapshot releases.

@kenglxn
Copy link
Owner

kenglxn commented Oct 14, 2014

@atomfrede yes I did mean that. Very strange that the comment shows up here. I thought I added the comment to your fork..

@kenglxn
Copy link
Owner

kenglxn commented Oct 14, 2014

Weird.. I added the comment here: atomfrede@6e9dbfd

Seems like github is experiencing some issues with comments right now..

@kenglxn
Copy link
Owner

kenglxn commented Oct 14, 2014

I have been too busy to get the 2.0 release.. shame on me :(

This week for sure.
Then we can look at getting your svg stuff into 2.1 :)

@kenglxn kenglxn mentioned this pull request Oct 14, 2014
@atomfrede
Copy link
Contributor Author

Ah! It' a commit comment. Forgot about my open PR when I merged this into my master branch therefore SVG support became part of this PR already :( Maybe just remove svg() for the 2.0 release (as it is already in your repository) and I'll do a little refactoring for 2.1

@kenglxn
Copy link
Owner

kenglxn commented Oct 14, 2014

I'd be fine with you just hiding it from the public API for 2.0, the we just expose it in 2.1

@atomfrede
Copy link
Contributor Author

Great will create another PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants