Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release of 2.7.0 #151

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Preparing release of 2.7.0 #151

merged 3 commits into from
Nov 24, 2022

Conversation

Lonzak
Copy link
Contributor

@Lonzak Lonzak commented Nov 23, 2022

Couldn't get the android stuff running since a lot of dependencies are missing. Except for that everything looks good...

- Fixed jdoc warnings
- updated dependencies
@Lonzak Lonzak mentioned this pull request Nov 23, 2022
@kenglxn
Copy link
Owner

kenglxn commented Nov 23, 2022

nice!
thanks @Lonzak I will look at this in the morning.

@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

Small update:
I started looking at the state of things this morning, and regardless of this PR the roboelectric stuff is just broken.
I spent some time trying to fix it, but it's a mess to be honest. Looks like they broke maven support a while back.

Long story short. I should be able to merge your changes, I just have to get a passing build set up. Which also means I have to throw out robolectric.

@Lonzak
Copy link
Contributor Author

Lonzak commented Nov 24, 2022

Yes I had the same impression with the roboelectric stuff. Strange thing. Thanks for the update...

PS: Maybe this helps? robolectric/robolectric#3344

@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

Yes I had the same impression with the roboelectric stuff. Strange thing. Thanks for the update...

PS: Maybe this helps? robolectric/robolectric#3344

Thanks. I spent quite some time looking into it, and decided to give up. If someone wants to reintroduce robolectric after the build is fixed without it that could be an option. I just dont have the time to fix it now.

@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

I will go ahead and merge this into a branch on my fork, and resolve the conflicts. It will be available as 3.0.0 since I had to bump to java 11

@kenglxn kenglxn changed the base branch from master to prepareV3_0_0 November 24, 2022 13:13
@Lonzak
Copy link
Contributor Author

Lonzak commented Nov 24, 2022

Ah really? So is the bytecode level also already java11? Damn we are still compiling with 8 ....

@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

Yes, I believe so. This project has been and is pretty idle for a long time

@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

I resolved the conflicts. Now I will merge this into my fork and create the 3.0.0 release.

@kenglxn kenglxn merged commit 30d1513 into kenglxn:prepareV3_0_0 Nov 24, 2022
@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

Thanks for the contrib @Lonzak 🎉

@Lonzak
Copy link
Contributor Author

Lonzak commented Nov 24, 2022

Thanks you as well!
Would it be possible to create a 2.7.0 compatible with Java8 (8 is better but 7 would also suffice)? Unfortunately version 3.0.0 is now not usable for me and every effort would be in vain :-/

@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

I'll give it a shot

@kenglxn
Copy link
Owner

kenglxn commented Nov 24, 2022

Can you try this https://jitpack.io/#kenglxn/qrgen/2.7.0
hopefully works

        <dependency>
	    <groupId>com.github.kenglxn</groupId>
	    <artifactId>qrgen</artifactId>
	    <version>2.7.0</version>
	</dependency>

@Lonzak
Copy link
Contributor Author

Lonzak commented Nov 24, 2022

I am trying out right now...Will update when it is working...
Update : After struggeling a bit with maven and the above mentioned repo I got it to work. So seems good! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants