Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Melgan #1168

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix Melgan #1168

merged 2 commits into from
Feb 21, 2024

Conversation

FusionBolt
Copy link
Contributor

  1. match more marker for marker rule
  2. fix conflict between two CombineTransposePad when shapebucket

@FusionBolt FusionBolt closed this Feb 20, 2024
@FusionBolt FusionBolt reopened this Feb 20, 2024
Copy link

Test Results

5 937 tests  ±0   5 937 ✅ ±0   8m 30s ⏱️ +13s
    6 suites ±0       0 💤 ±0 
    6 files   ±0       0 ❌ ±0 

Results for commit 16492c1. ± Comparison against base commit a562682.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (a562682) 73.11% compared to head (16492c1) 73.02%.

Files Patch % Lines
...ncase.Passes/Rules/WithMarker/CombineReshapePad.cs 21.05% 29 Missing and 1 partial ⚠️
src/Nncase.Compiler/Compiler.cs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
- Coverage   73.11%   73.02%   -0.09%     
==========================================
  Files         707      707              
  Lines       26007    26042      +35     
  Branches     4244     4247       +3     
==========================================
+ Hits        19014    19018       +4     
- Misses       6347     6377      +30     
- Partials      646      647       +1     
Flag Coverage Δ
integration 39.19% <35.41%> (-0.04%) ⬇️
unit 64.49% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangyang2057 zhangyang2057 merged commit 699f198 into master Feb 21, 2024
22 of 24 checks passed
@zhangyang2057 zhangyang2057 deleted the fix/melgan branch February 21, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants