Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates feature gate to use new_zeroed_alloc #9

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wasv
Copy link

@wasv wasv commented Oct 10, 2024

Needed in order to build with newest nightly

new_zeroed_alloc is a more specific version of new_uninit as introduced in:

rust-lang/rust#129396

P.S. I only noticed this because I'm trying to build dust for NixOS. Any interest in a PR to put the NixOS package definitions alongside the source itself? It'd be a nix subdirectory, a flake.nix and a flake.lock that'd be added.

Needed in order to build with newest nightly

More specific version of new_uninit as introduced in

rust-lang/rust#129396
@wasv wasv marked this pull request as draft October 10, 2024 04:02
@wasv
Copy link
Author

wasv commented Oct 10, 2024

I meant to mark this as a draft beforehand, since I haven't built it yet. Will mark as "ready for review" once I've gotten it to run.

@wasv
Copy link
Author

wasv commented Oct 13, 2024

At this point I've gotten it to build and almost run. I get an unrelated error due to some alsa shared libraries, but thats on my end. I also had to do some hacky stuff in my local Cargo.lock to try test it with my emu-utils PR. Once kelpsyberry/emu-utils#1 is merged though, this can be merged as well.
Only the feature gate changed, nothing logic related, so I dont know of any way to test this beyond "cargo actually lets it build now".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant