Skip to content

Bump Xunit.StaFact from 1.1.11 to 3.0.13#84

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/QuickMail.Tests/Xunit.StaFact-3.0.13
Closed

Bump Xunit.StaFact from 1.1.11 to 3.0.13#84
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/QuickMail.Tests/Xunit.StaFact-3.0.13

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updated Xunit.StaFact from 1.1.11 to 3.0.13.

Release notes

Sourced from Xunit.StaFact's releases.

3.0.13

What's Changed

New Contributors

Full Changelog: AArnott/Xunit.StaFact@v2.1.7...v3.0.13

3.0.6-alpha

What's Changed

New Contributors

Full Changelog: AArnott/Xunit.StaFact@v2.1.7...v3.0.6-alpha

2.1.7

What's Changed

New Contributors

Full Changelog: AArnott/Xunit.StaFact@v2.0.44...v2.1.7

2.1.4-alpha

What's Changed

New Contributors

Full Changelog: AArnott/Xunit.StaFact@v2.0.36-alpha...v2.1.4-alpha

2.0.44

What's Changed

Full Changelog: AArnott/Xunit.StaFact@v1.2.69...v2.0.44

2.0.36-alpha

What's Changed

Full Changelog: AArnott/Xunit.StaFact@v2.0.35-alpha...v2.0.36-alpha

2.0.35-alpha

What's Changed

Full Changelog: AArnott/Xunit.StaFact@v2.0.29-alpha...v2.0.35-alpha

2.0.29-alpha

Enhancements

New Contributors

Full Changelog: AArnott/Xunit.StaFact@v1.2.46-alpha...v2.0.29-alpha

1.2.69

Enhancements

Other changes

New Contributors

Full Changelog: AArnott/Xunit.StaFact@v1.1.11...v1.2.69

1.2.46-alpha

What's Changed

New Contributors

Full Changelog: AArnott/Xunit.StaFact@v1.2.22-alpha...v1.2.46-alpha

1.2.22-alpha

What's Changed

New Contributors

Full Changelog: AArnott/Xunit.StaFact@v1.1.11...v1.2.22-alpha

Commits viewable in compare view.

@dependabot
dependabot Bot requested a review from kellylford as a code owner June 14, 2026 19:52
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Jun 14, 2026
kellylford
kellylford requested changes Jun 14, 2026
View reviewed changes

@kellylford kellylford left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails because Xunit.StaFact 3.x requires xUnit v3, but this project is on xUnit 2.9.3. This is not a drop-in upgrade — it is a migration.

Options:

  1. Skip this version for now — comment @dependabot ignore this major version to suppress future 3.x PRs until you are ready to migrate.
  2. Migrate to xUnit v3 — also requires bumping xunit, xunit.runner.visualstudio, and Microsoft.NET.Test.Sdk together. Non-trivial but doable; PRs #81 and #83 are already approved and waiting, which would be part of that bundle.

Holding until a decision is made.

@dependabot
dependabot Bot force-pushed the dependabot/nuget/QuickMail.Tests/Xunit.StaFact-3.0.13 branch 6 times, most recently from 7f78b0e to 40d7356 Compare June 19, 2026 19:39
@dependabot
Bump Xunit.StaFact from 1.1.11 to 3.0.13
52ccf9c 
---
updated-dependencies:
- dependency-name: Xunit.StaFact
  dependency-version: 3.0.13
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/nuget/QuickMail.Tests/Xunit.StaFact-3.0.13 branch from 40d7356 to 52ccf9c Compare June 21, 2026 23:25
@kellylford kellylford mentioned this pull request Jun 22, 2026
Merged
3 tasks
kellylford added a commit that referenced this pull request Jun 22, 2026
@kellylford
chore: migrate test project from xunit v2 to xunit.v3 (#122)
8576bdc 
Replace xunit 2.9.3 with xunit.v3 3.2.2 and bump Xunit.StaFact from 1.1.11 to 3.0.13. Add SelfContained=true to satisfy NETSDK1151 triggered by xunit.v3's build targets (UseAppHost=true). 727/727 tests pass. Closes Dependabot PR #84.
@kellylford

kellylford commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Superseded by #122, which does the full xunit v3 migration rather than accepting just the StaFact bump in isolation. Running xunit v2 and xunit v3 side-by-side causes CS0433 type-ambiguity errors; PR #122 removes xunit 2.9.3 entirely and upgrades to xunit.v3 3.2.2 + StaFact 3.0.13. All 727 tests pass on CI.

@kellylford kellylford closed this Jun 22, 2026
@dependabot @github

dependabot Bot commented on behalf of github Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/nuget/QuickMail.Tests/Xunit.StaFact-3.0.13 branch June 22, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kellylford kellylford kellylford requested changes

Assignees

@kellylford kellylford

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kellylford