Expose race case with ubuntu container #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelindar
reviewed
Jul 5, 2022
txn.go
Outdated
| @@ -514,9 +514,11 @@ func (txn *Txn) commitUpdates(chunk commit.Chunk) (updated bool) { | |||
|
|
|||
| // Range through all of the pending updates and apply them to the column | |||
| // and its associated computed columns. | |||
| txn.owner.lock.Lock() | |||
There was a problem hiding this comment.
Wouldn't the chunk be already locked? I'm afraid that we'd limit concurrency significantly as only a single writer would be allowed to apply the transaction concurrently in this case. Now, that might not be too bad but I wonder if there's some better way instead of locking the entire Apply?
There was a problem hiding this comment.
Unfortunately, I'm not able to work around locking the fill map completely - but I think I've come up with a quicker method that still (seems) to fix the race.
|
As an aside, I can't seem to bring the coverage back up to 100%, and can't figure out why. I think the snapshot recorder has a bug with the commit IDs within certain collection sizes |
kelindar
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've managed to reliably replicate the race case found in multiple git workflow runs. This requires using a docker container that mocks the specifications of the Github Actions environment, while increasing the exposure area of the edge case within TestSnapshot.