-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add type hints and mypy support #306
Conversation
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Hello, thanks for this! Did you use Black on the code? If so, could you please add it to CI? |
Signed-off-by: Alvaro Frias Garay <[email protected]>
@skorokithakis I've added a CI job for check black linting 👍 |
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
black job Signed-off-by: Alvaro Frias Garay <[email protected]>
This looks good, thank you! To speed up the review, is there any way you could make your changes to schema.py and not run Black on it? Then I can review only your changes, and I'll run Black and push to your PR, and then merge. |
@skorokithakis tough I ran Black there are no significant changes made on the code by Black. At most there are three or four methods/functions signatures formatted to multiple lines, but most of the code remains unchanged |
Oh, all those changes are manual? OK, I will review ASAP, thanks! |
@skorokithakis any updates on this? |
Sorry, this looks good to me. Which Python versions can run this? I worry that it uses syntax that's a bit too recent... |
Signed-off-by: Alvaro Frias Garay <[email protected]>
@skorokithakis I have made some updates and tested it up to python3.6 and works normally |
When you say "up to", what do you mean? 2.7 to 3.6? Surely it can't be 2.7-compatible any more. |
@skorokithakis I've tested from 3.6 to 3.10 and works fine. 3.5 and backwards versions doesn't support types |
In that case, that's fine, but the setup.py classifiers/etc needs to be changed to the proper supported versions. |
Signed-off-by: Alvaro Frias Garay <[email protected]>
@skorokithakis updated classifiers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Updated package so it's mypy compatible
Fixes #296