Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add TS types check #690

Merged
merged 1 commit into from
Aug 26, 2023
Merged

test: add TS types check #690

merged 1 commit into from
Aug 26, 2023

Conversation

sheerlox
Copy link
Collaborator

Description

Imported and adapted the types test file from @types/cron.

Note: The tests won't pass until #689 is merged since they detect the issue it fixes.

Related Issue

Motivation and Context

This adds more safety to our workflow regarding TypeScript types. Note that this only statically checks the types, so there is no assurance the runtime types would match.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@sheerlox sheerlox self-assigned this Aug 16, 2023
@sheerlox sheerlox merged commit f046016 into kelektiv:main Aug 26, 2023
10 checks passed
ncb000gt pushed a commit that referenced this pull request Aug 26, 2023
@semantic-release-bot
Release v2.4.3 [skip ci]
0317684 
## [2.4.3](v2.4.2...v2.4.3) (2023-08-26)

### 🐛 Bug Fixes

* fix range parsing when upper limit = 0 ([#687](#687)) ([d96746f](d96746f))

### 🚨 Tests

* add TS types check ([#690](#690)) ([f046016](f046016))
@ncb000gt
Copy link
Member

🎉 This PR is included in version 2.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 10, 2023
@sheerlox
test: add TS types check (kelektiv#690)
21b4aec
ncb000gt pushed a commit that referenced this pull request Sep 10, 2023
@semantic-release-bot
Release v3.0.0-beta.4 [skip ci]
ae16565 
## [3.0.0-beta.4](v3.0.0-beta.3...v3.0.0-beta.4) (2023-09-10)

### 🐛 Bug Fixes

* **deps:** update dependency luxon to v3.3.0 & add [@types](https://github.com/types)/luxon ([#689](#689)) ([c95a449](c95a449)), closes [#688](#688)
* fix range parsing when upper limit = 0 ([#687](#687)) ([d96746f](d96746f))

### 🚨 Tests

* add TS types check ([#690](#690)) ([f046016](f046016))
@ncb000gt
Copy link
Member

🎉 This PR is included in version 3.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sheerlox sheerlox deleted the test/add-typings-tests branch September 10, 2023 15:17
patrickm68 added a commit to patrickm68/node-cron-types that referenced this pull request Sep 14, 2023
@patrickm68
Release v2.4.3 [skip ci]
eb90872 
## [2.4.3](kelektiv/node-cron@v2.4.2...v2.4.3) (2023-08-26)

### 🐛 Bug Fixes

* fix range parsing when upper limit = 0 ([#687](kelektiv/node-cron#687)) ([d96746f](kelektiv/node-cron@d96746f))

### 🚨 Tests

* add TS types check ([#690](kelektiv/node-cron#690)) ([f046016](kelektiv/node-cron@f046016))
sheerlox added a commit that referenced this pull request Sep 27, 2023
@sheerlox
test: add TS types check (#690)
2f4ef93
sheerlox pushed a commit that referenced this pull request Sep 27, 2023
@semantic-release-bot @sheerlox
Release v2.4.3 [skip ci]
22f3ec4 
## [2.4.3](v2.4.2...v2.4.3) (2023-08-26)

### 🐛 Bug Fixes

* fix range parsing when upper limit = 0 ([#687](#687)) ([d96746f](d96746f))

### 🚨 Tests

* add TS types check ([#690](#690)) ([f046016](f046016))
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 27, 2023
@sheerlox
test: add TS types check (kelektiv#690)
7426a7e
sheerlox pushed a commit to sheerlox/node-cron that referenced this pull request Sep 27, 2023
@semantic-release-bot @sheerlox
Release v2.4.3 [skip ci]
8f26b7c 
## [2.4.3](kelektiv/node-cron@v2.4.2...v2.4.3) (2023-08-26)

### 🐛 Bug Fixes

* fix range parsing when upper limit = 0 ([kelektiv#687](kelektiv#687)) ([d96746f](kelektiv@d96746f))

### 🚨 Tests

* add TS types check ([kelektiv#690](kelektiv#690)) ([f046016](kelektiv@f046016))
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
@sheerlox
test: add TS types check (kelektiv#690)
4d8401a
sheerlox pushed a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
@semantic-release-bot @sheerlox
Release v2.4.3 [skip ci]
b69affd 
## [2.4.3](kelektiv/node-cron@v2.4.2...v2.4.3) (2023-08-26)

### 🐛 Bug Fixes

* fix range parsing when upper limit = 0 ([kelektiv#687](kelektiv#687)) ([d96746f](kelektiv@d96746f))

### 🚨 Tests

* add TS types check ([kelektiv#690](kelektiv#690)) ([f046016](kelektiv@f046016))
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
@sheerlox
test: add TS types check (kelektiv#690)
1d40539
@sheerlox sheerlox added type:test Adding missing tests or correcting existing tests and removed released on @beta labels Sep 30, 2023
@sheerlox sheerlox removed their assignment Oct 23, 2023
@j-mendez j-mendez mentioned this pull request May 25, 2024
Open
This was referenced Sep 8, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intcreator intcreator intcreator approved these changes

Assignees
No one assigned
Labels
released type:test Adding missing tests or correcting existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheerlox @ncb000gt @intcreator