-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Madtheme: fix chapters fetching #7270
Conversation
Seems like the wrong abstraction layer? Is this something that is better scoped for each site? Or entry? Is the only way to check definitely by testing both endpoints? Also, from the user's point of view this is an implementation detail that is hard to take a position on. |
Either I think, I didn't test it too much but depends on the site and/or entry, there are some site that the updated chapter list is by Id and others are by slug
Yes I think so, the original issue #3976 in this case
I could add a new option that includes both, that will compare the two requests and choose the one with more chapters. |
Could the difference be that when there are less than x chapters using the 'show more' API is only done by non-users and should not be done? If you can't use that heuristic I would fetch both regardless -- the user still can't take a position site-wide, imo. |
I think the best approach it's just call both endpoints and fetch the one that has more chapters. |
Closes #7268
Checklist:
extVersionCode
value inbuild.gradle
for individual extensionsoverrideVersionCode
orbaseVersionCode
as needed for all multisrc extensionsisNsfw = true
flag inbuild.gradle
when appropriateid
if a source's name or language were changedweb_hi_res_512.png
when adding a new extension