Skip to content

chore(claude): add mattpocock/skills plugin - #971

Merged
keito4 merged 2 commits into
mainfrom
chore/add-mattpocock-skills-plugin
Jul 14, 2026
Merged

chore(claude): add mattpocock/skills plugin#971
keito4 merged 2 commits into
mainfrom
chore/add-mattpocock-skills-plugin

Conversation

@keito4

@keito4 keito4 commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Why

Matt Pocock の mattpocock/skills(MIT・53k+ stars)を全端末の Claude Code に配布する。実務エンジニアリングのフロー(アイデア→徹底ヒアリング→仕様→チケット→TDD→アーキテクチャ改善)を回すためのスキル群。ローカルで動作確認済みのため config リポジトリに反映して各端末へ展開する。

What

管理型 Claude Code プラグインとして mattpocock-skills@mattpocock(v1.2.0 / 全22スキル)を追加。

  • .claude/plugins/plugins.txt: mattpocock-skills@mattpocock を追加
  • .claude/plugins/known_marketplaces.json.template: mattpocock マーケットプレイス(mattpocock/skills)を追加
  • script/lib/claude_plugins.sh: フォールバック配列に mattpocock:mattpocock/skills を追加(テンプレートと同期)
  • .claude/plugins/README.md: 利用可能なマーケットプレイス一覧に追記

主なスキル: grill-me / grill-with-docs / to-spec / to-tickets / tdd / improve-codebase-architecture / code-review / implement ほか。

How

各端末で make claude-setupsetup-claude.sh)を実行すると、plugins.txt からユーザースコープでインストールされる。
導入後、各リポジトリで一度だけ /setup-matt-pocock-skills を実行し、issueトラッカー・triageラベル・docs保存先を設定する。

Risk

  • 読み取り専用の管理型プラグインのため既存設定を汚さない。低リスク。
  • JSON妥当性(jq empty)・shellcheck ともにパス済み。
  • 既存プラグイン/マーケットプレイスとの名前衝突なし。

Summary by CodeRabbit

  • New Features
    • Added the Matt Pocock Skills marketplace and Claude Code plugin.
    • Included setup guidance to run /setup-matt-pocock-skills once per repository after installation.
    • Added fallback marketplace support for environments without marketplace metadata.

Matt Pocock の実務エンジニアリング向けスキル群を全端末に配布する。
grill-me / to-spec / to-tickets / tdd / improve-codebase-architecture ほか
22スキルを管理型プラグインとして導入(自動更新・読み取り専用)。

- plugins.txt: mattpocock-skills@mattpocock を追加
- known_marketplaces.json.template: mattpocock マーケットプレイスを追加
- claude_plugins.sh: フォールバック配列に mattpocock:mattpocock/skills を追加
- .claude/plugins/README.md: 利用可能なマーケットプレイス一覧に追記

導入後、各リポジトリで /setup-matt-pocock-skills を1回実行する。
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@keito4, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bdaddaee-c2bb-4ef6-9487-1bef5231c540

📥 Commits

Reviewing files that changed from the base of the PR and between e7ad983 and 4cda480.

📒 Files selected for processing (1)
  • test/integration/audit_references.bats
📝 Walkthrough

Walkthrough

Adds the mattpocock/skills marketplace and mattpocock-skills plugin to Claude plugin configuration, marketplace templates, documentation, and fallback settings.

Changes

Claude plugin marketplace registration

Layer / File(s) Summary
Marketplace and plugin entry
.claude/plugins/plugins.txt, .claude/plugins/known_marketplaces.json.template, .claude/plugins/README.md, script/lib/claude_plugins.sh
Registers the Matt Pocock Skills plugin, marketplace source and installation metadata, documentation entry, and fallback marketplace mapping.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • keito4/config#170: Updates Claude plugin configuration handling and marketplace synchronization.
  • keito4/config#186: Introduces the template-based marketplace setup extended by this change.
  • keito4/config#474: Updates the fallback marketplace configuration in script/lib/claude_plugins.sh.

Suggested labels: size/S

Suggested reviewers: github-actions[bot]

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title concisely describes the main change: adding the mattpocock/skills plugin.
Description check ✅ Passed The description covers the why, what, how, and risk, but it omits template sections like Summary, How to test, Checklist, and Related.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/add-mattpocock-skills-plugin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keito4's task in 0s —— View job


I'll analyze this and get back to you.

f98d5b0 で test/template-workflows.test.js を分割・削除した際、
audit_references.bats が旧ファイル名への参照行を期待したまま残っていた。
分割後の実体 test/template-workflows-claude.test.js に修正する。

main への push 時はパスゲートで Integration Tests がスキップされ表面化して
いなかったが、script/ を変更する本PRでジョブが起動し顕在化した。
@keito4

keito4 commented Jul 14, 2026

Copy link
Copy Markdown
Owner Author

追記: 既存テスト失敗の修正(本PRとは無関係な既存バグ)

初回CIで Integration Tests / Quality Gate が失敗しましたが、原因は本PRの変更(プラグイン追加)とは無関係でした。

  • 失敗テスト: test/integration/audit_references.batsaudit-references reports references as TSV with required categories
  • 根本原因: コミット f98d5b0(テストファイル分割リファクタ)で test/template-workflows.test.js が分割・削除されたのに、audit_references.bats が旧ファイル名への参照行を期待したまま残存していた。
  • なぜ今表面化したか: main への push 時は Detect Changes のパスゲートで Integration Tests がスキップされ緑に見えていた。本PRが script/lib/ を変更したため当該ジョブが起動し、既存バグが顕在化した。
  • 修正: 期待行を分割後の実体 test/template-workflows-claude.test.js に更新(1行)。ローカルで bats test/integration/audit_references.bats が 2/2 pass することを確認済み。

CLAUDE.md の「間接的な影響によるCI失敗 → そのブランチで修正可能なら修正」に従い本PRに含めています。

@keito4
keito4 merged commit df35365 into main Jul 14, 2026
17 checks passed
@keito4
keito4 deleted the chore/add-mattpocock-skills-plugin branch July 14, 2026 14:03
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.123.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released リリース済み label Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released リリース済み

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant