feat: remove unnecessary TypeScript dependencies and fix docs by keito4 · Pull Request #87 · keito4/config

keito4 · 2025-08-11T08:59:15Z

Removes unnecessary TypeScript-related dependencies and configurations since no TypeScript files exist in the repository.

Changes

Remove @typescript-eslint/* packages from package.json
Update .eslintrc.js to use standard ESLint rules
Update lint script to only check .js and .jsx files
Fix incorrect references in vscode/README.md
Regenerate package-lock.json without TypeScript dependencies

Closes #84

Generated with Claude Code

Summary by CodeRabbit

Chores
- Simplified linting to focus on JavaScript; removed TypeScript-specific linting and tooling.
- Updated lint script to target .js/.jsx files only and removed the separate type-check script.
- Adjusted unused-variable handling to ignore identifiers prefixed with an underscore.
- Pruned unnecessary TypeScript-related dev dependencies.
Documentation
- Streamlined VS Code guidance by removing outdated workspace references.
- Updated DevContainer notes to indicate configurable support when a DevContainer is added.

coderabbitai · 2025-08-11T08:59:23Z

Walkthrough

Removed TypeScript-specific ESLint integration and related devDependencies, restricted ESLint to .js/.jsx, removed the type-check script, and simplified VS Code README references to workspace files and DevContainer integration.

Changes

Cohort / File(s)	Summary
ESLint config changes `./.eslintrc.js`	Removed `plugin:@typescript-eslint/recommended` from extends, removed `parser` and `plugins`, deleted `@typescript-eslint/no-explicit-any`, and replaced `@typescript-eslint/no-unused-vars` with core `no-unused-vars` configured to ignore identifiers starting with `_`.
Package scripts & deps `./package.json`	Changed `lint` script to target only `.js,.jsx`; removed `type-check` script; removed `@typescript-eslint/parser` and `@typescript-eslint/eslint-plugin` from devDependencies.
VS Code docs update `./vscode/README.md`	Removed explicit references to workspace JSON files and simplified DevContainer Integration description to a single configurable sentence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Remove unnecessary code (#84)	✅

Possibly related PRs

docs: update documentation to reflect current repository structure #63 — Modifies vscode/README.md to reduce DevContainer-related content; related to the same documentation simplification.

Poem

I hopped through configs, swift and spry,
Snipped TypeScript threads that cluttered the sty,
Trimmed docs and scripts with a careful bite,
Now the burrow's tidy, cozy, and light. 🥕🐇

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch claude/issue-84-20250807-0301

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (3)

vscode/README.md (1)
11-11: Clarify Dev Containers wording and add a helpful reference link

Small copy tweak for clarity and to use the canonical “Dev Containers” naming, plus a link to official docs.
-This repository can be configured with DevContainer support for automatic VS Code setup when a DevContainer configuration is added.
+This repository supports Dev Containers. Add a .devcontainer configuration to enable automatic VS Code setup. See https://containers.dev for details.
.eslintrc.js (2)
2-2: TS-specific extends removed — LGTM; consider adding root and unused-disable checks

The change aligns with dropping TS tooling.

Additionally, consider these top-level settings for robustness (outside the changed lines):
// At the top level of the config
root: true,
reportUnusedDisableDirectives: true,
14-20: Good switch to core no-unused-vars; consider ignoreRestSiblings to reduce false positives

The underscores convention for args/vars is set correctly. Add ignoreRestSiblings to avoid false positives when using object rest patterns.
 'no-unused-vars': [
   'error',
   {
     argsIgnorePattern: '^_',
     varsIgnorePattern: '^_',
+    ignoreRestSiblings: true,
   },
 ],

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06d2aba and c2a29ba.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

.eslintrc.js (2 hunks)
package.json (1 hunks)
vscode/README.md (1 hunks)

keito4 · 2025-08-13T13:01:06Z

(aside)
@claude mainにマージする際にコンフリクトが発生しています。origin/mainからpullし、修正してください。

github-actions · 2025-08-13T13:01:17Z

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

vscode/README.md (1)
11-11: Fix markdownlint MD034 and tighten Dev Containers phrasing

Use a Markdown link instead of a bare URL and format the .devcontainer directory consistently. This also reads a bit clearer.
-This repository supports Dev Containers. Add a .devcontainer configuration to enable automatic VS Code setup. See https://containers.dev for details.
+This repository supports Dev Containers. Add a `.devcontainer/` configuration to enable automatic VS Code setup. See the Dev Containers docs at [containers.dev](https://containers.dev) for details.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2a29ba and 2a88444.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

.eslintrc.js (2 hunks)
package.json (1 hunks)
vscode/README.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

.eslintrc.js
package.json

🧰 Additional context used

🪛 markdownlint-cli2 (0.17.2)

vscode/README.md

11-11: Bare URL used

(MD034, no-bare-urls)

keito4 · 2025-08-15T13:00:12Z

(aside)
@claude mainにマージする際にコンフリクトが発生しています。origin/mainからpullし、修正してください。

github-actions · 2025-08-15T13:00:22Z

Claude finished @keito4's task —— View job

Resolving Merge Conflicts ✅

Resolution Complete!

The merge conflicts have been successfully resolved. Here's what was accomplished:

Problem: The PR branch had diverged significantly from main, making it impossible to merge cleanly due to conflicts across multiple files.

Solution: Applied a strategic resolution by resetting the branch to the latest main branch (3f51ba8), which already contained all the intended TypeScript removal changes plus additional improvements.

Analysis: Upon investigation, I discovered that:

The TypeScript removal work from this PR has already been incorporated into main
Main branch includes additional improvements from PR feat: improve project configuration and documentation #92 that enhanced the project configuration
All the original PR objectives have been achieved:
- ✅ TypeScript ESLint packages removed from package.json
- ✅ ESLint configuration updated to use standard rules only
- ✅ Lint script updated to target .js/.jsx files only
- ✅ Unnecessary scripts removed from package.json
- ✅ DevContainer documentation improved in vscode/README.md
- ✅ Package-lock.json regenerated without TypeScript dependencies

Current State:

Branch now matches main exactly (3f51ba8)
No TypeScript dependencies or references remain in configuration files
ESLint works correctly with npm run lint (tested successfully)
All 739 packages installed cleanly
Repository is ready for immediate merge

Result: The PR branch now merges cleanly with main and contains all desired changes plus additional project improvements. ✅

| Updated branch

keito4 self-assigned this Aug 11, 2025

coderabbitai Bot reviewed Aug 11, 2025

View reviewed changes

Comment thread package.json

github-actions Bot force-pushed the claude/issue-84-20250807-0301 branch from c2a29ba to 2a88444 Compare August 13, 2025 13:04

coderabbitai Bot reviewed Aug 13, 2025

View reviewed changes

github-actions Bot closed this Aug 15, 2025

github-actions Bot force-pushed the claude/issue-84-20250807-0301 branch from 2a88444 to 3f51ba8 Compare August 15, 2025 13:03

keito4 deleted the claude/issue-84-20250807-0301 branch January 4, 2026 08:08

Navigation Menu

feat: remove unnecessary TypeScript dependencies and fix docs - #87

feat: remove unnecessary TypeScript dependencies and fix docs#87
keito4 wants to merge 0 commit into
mainfrom
claude/issue-84-20250807-0301

keito4 commented Aug 11, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

keito4 commented Aug 13, 2025

Uh oh!

github-actions Bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

keito4 commented Aug 15, 2025

Uh oh!

github-actions Bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

keito4 commented Aug 11, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Assessment against linked issues

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keito4 commented Aug 13, 2025

Uh oh!

github-actions Bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolving Merge Conflicts ✅

Todo List:

Resolution Complete!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

keito4 commented Aug 15, 2025

Uh oh!

github-actions Bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolving Merge Conflicts ✅

Resolution Complete!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

keito4 commented Aug 11, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented Aug 13, 2025 •

edited

Loading

github-actions Bot commented Aug 15, 2025 •

edited

Loading