fix: settle environment source of truth - #854
Conversation
|
Warning Review limit reached
More reviews will be available in 59 minutes and 59 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughEstablishes ADR 0012 as the environment ownership record for the repository. DevContainer feature lists are pruned to remove tools already present in the base image. npm is declared the canonical package manager while pnpm is retained solely for supply-chain guardrails. Intentional Codex/Gemini MCP server set differences are documented in config comments. Credential templates are updated to reflect the ChangesEnvironment Source of Truth Refactor
CI / Security: Trivy CVE Ignore List Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@credentials/README.md`:
- Around line 48-60: The table in the credentials README is missing entries for
two MCP servers that are configured in .codex/config.toml: aws-knowledge and
context7. Add two new rows to the table following the same structure as the
existing entries, with aws-knowledge and context7 as the MCPサーバー names, .codex
as the 設定ファイル value, no required environment variables (なし in the 必要な環境変数
column), and appropriate Japanese descriptions for each server's functionality
in the 説明 column.
In `@credentials/setup.md`:
- Around line 61-63: In the credentials/setup.md file, split the current
combined N8N configuration item into two separate items to match the
mcp.env.template expectations. Create one item for N8N_API_URL with its
description and configuration details, then create a second separate item for
N8N_API_KEY with its own description and configuration details. Each should be
independently documented as separate 1Password lookups rather than being grouped
together as a single combined item.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9287efb4-ef96-419d-ad12-c2c7b210254d
📒 Files selected for processing (16)
.codex/config.toml.context/issue-819-environment-diff.md.devcontainer/codespaces/devcontainer.json.devcontainer/devcontainer.json.gemini/README.md.trivyignorecredentials/README.mdcredentials/setup.mdcredentials/templates/devcontainer.env.templatecredentials/templates/mcp.env.templatedocs/adr/0012-environment-source-of-truth.mddocs/adr/README.mddocs/tool-catalog.mdpackage.jsonpnpm-workspace.yamltest/integration/credentials_templates.bats
| | MCPサーバー | 設定ファイル | 必要な環境変数 | 説明 | | ||
| | ------------------- | ------------------- | --------------------------------------------- | ------------------------- | | ||
| | **Playwright** | `.codex`, `.gemini` | なし | ブラウザ自動化とテスト | | ||
| | **AWS Docs** | `.codex`, `.gemini` | なし | AWS ドキュメント検索 | | ||
| | **Chrome DevTools** | `.codex`, `.gemini` | なし | ブラウザデバッグ | | ||
| | **Next DevTools** | `.codex`, `.gemini` | なし | Next.js 開発支援 | | ||
| | **Supabase** | `.codex`, `.gemini` | `SUPABASE_ACCESS_TOKEN`, `SUPABASE_MCP_TOKEN` | Supabase プロジェクト操作 | | ||
| | **Vercel** | `.codex`, `.gemini` | `VERCEL_TOKEN`, `VERCEL_MCP_TOKEN` | Vercel 操作 | | ||
| | **GitHub** | `.gemini` | `GITHUB_COPILOT_MCP_TOKEN` | Gemini の GitHub MCP 接続 | | ||
| | **o3** | `.codex` | `OPENAI_API_KEY` | Web/検索支援 | | ||
| | **Linear** | `.codex` | `LINEAR_API_KEY` | Linear 課題操作 | | ||
| | **Doppler** | `.codex` | `DOPPLER_TOKEN` | Secret 管理 | | ||
| | **n8n** | optional/manual | `N8N_API_URL`, `N8N_API_KEY` | n8n ワークフロー自動化 | |
There was a problem hiding this comment.
Add the missing Codex-only MCP servers.
aws-knowledge and context7 are still configured in .codex/config.toml, but this table never mentions them. Please add rows for both (they need no extra env vars) or explicitly say the table is env-backed only; otherwise the new MCP inventory is incomplete.
🛠 Suggested rows
+| **AWS Knowledge** | `.codex` | なし | AWS Knowledge lookup |
+| **Context7** | `.codex` | なし | Context7 docs lookup |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@credentials/README.md` around lines 48 - 60, The table in the credentials
README is missing entries for two MCP servers that are configured in
.codex/config.toml: aws-knowledge and context7. Add two new rows to the table
following the same structure as the existing entries, with aws-knowledge and
context7 as the MCPサーバー names, .codex as the 設定ファイル value, no required
environment variables (なし in the 必要な環境変数 column), and appropriate Japanese
descriptions for each server's functionality in the 説明 column.
| - アイテム名: `N8N_API_URL`, `N8N_API_KEY` | ||
| - フィールド: | ||
| - `value`: optional n8n MCP 用 |
There was a problem hiding this comment.
Split the N8N setup example into two items.
credentials/templates/mcp.env.template expects separate 1Password lookups for N8N_API_URL and N8N_API_KEY, but this section reads like a single combined item. Split them so the setup guide matches the template contract.
🛠 Suggested fix
-- アイテム名: `N8N_API_URL`, `N8N_API_KEY`
-- フィールド:
-- - `value`: optional n8n MCP 用
+- アイテム名: `N8N_API_URL`
+- フィールド:
+- - `value`: n8n MCP 用
+
+- アイテム名: `N8N_API_KEY`
+- フィールド:
+- - `value`: n8n MCP 用📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - アイテム名: `N8N_API_URL`, `N8N_API_KEY` | |
| - フィールド: | |
| - `value`: optional n8n MCP 用 | |
| - アイテム名: `N8N_API_URL` | |
| - フィールド: | |
| - `value`: n8n MCP 用 | |
| - アイテム名: `N8N_API_KEY` | |
| - フィールド: | |
| - `value`: n8n MCP 用 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@credentials/setup.md` around lines 61 - 63, In the credentials/setup.md file,
split the current combined N8N configuration item into two separate items to
match the mcp.env.template expectations. Create one item for N8N_API_URL with
its description and configuration details, then create a second separate item
for N8N_API_KEY with its own description and configuration details. Each should
be independently documented as separate 1Password lookups rather than being
grouped together as a single combined item.
|
🎉 This PR is included in version 1.118.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
Summary
Closes #819
Verification
Summary by CodeRabbit
New Features
script/credentials.sh fetch.Documentation
Chores