Skip to content

ci: Claude Code テンプレートの timeout を 30 分に延長 - #831

Merged
keito4 merged 1 commit into
mainfrom
ci/claude-timeout-30
Jun 16, 2026
Merged

ci: Claude Code テンプレートの timeout を 30 分に延長#831
keito4 merged 1 commit into
mainfrom
ci/claude-timeout-30

Conversation

@keito4

@keito4 keito4 commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Why

配布先リポジトリ(Elu-co-jp/job_description #754)で @claude 実行が 20 分上限に達し、調査完了後の実装〜PR作成途中でキャンセルされた。提案テンプレート側のデフォルトも引き上げ、配布先で同じ詰まりが起きにくくする。

What

  • templates/workflows/claude.yml: timeout-minutes: 2030、カスタマイズ説明コメントの デフォルト: 20分30分
  • .github/workflows/claude.yml(config 自身): timeout-minutes: 2030

How

ランナウェイ防止の上限は維持しつつ、コスト増を抑えた穏当な 30 分に設定。test/template-workflows.test.jstimeout-minutes: の存在のみ検証するため値変更による破綻なし。

Risk

低。

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Extended automated workflow execution timeout from 20 to 30 minutes, allowing background processing tasks additional time to complete before timing out.

配布テンプレートと config 自身のワークフローを更新。20分上限で
実装途中にキャンセルされるケースがあったため。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The timeout-minutes for the claude job is increased from 20 to 30 in both .github/workflows/claude.yml and templates/workflows/claude.yml. The template's inline configuration comment is also updated to reflect the new default value.

Changes

Claude Job Timeout Increase

Layer / File(s) Summary
timeout-minutes updated in workflow and template
.github/workflows/claude.yml, templates/workflows/claude.yml
The claude job's timeout-minutes is changed from 20 to 30 in the active workflow; the template file receives the same value change plus an updated inline comment reflecting the new default.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • keito4/config#16: Modifies the same jobs.claude.timeout-minutes field in .github/workflows/claude.yml, changing the value from 20 to 30.
  • keito4/config#564: Directly modifies the same jobs.claude.timeout-minutes setting in both the workflow and template files (reverting the timeout from 30 back to 20).

Suggested labels

size/XS

Poem

🐇 Tick-tock, the clock gets a stretch,
Twenty minutes? Too short a fetch!
Thirty now, the Claude job can run,
More time to think 'neath the CI sun.
Hippity-hop, the timeout is done! 🕐

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: extending the Claude Code template timeout from 20 to 30 minutes, which matches the PR's core objective.
Description check ✅ Passed The PR description follows the template structure with all required sections completed: Why (rationale for the change), What (specific file modifications), How (implementation approach), Risk assessment, and appropriate context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/claude-timeout-30

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keito4's task in 1m 9s —— View job


コードレビュー結果

  • 変更ファイルの確認
  • レビューフィードバックの作成

総評

承認(APPROVE) — 変更は明確な動機に基づいており、影響範囲も限定的です。


変更内容の確認

ファイル 変更内容
.github/workflows/claude.yml:51 timeout-minutes: 20 → 30
templates/workflows/claude.yml:66 timeout-minutes: 20 → 30
templates/workflows/claude.yml:13 コメント内の デフォルト: 20分30分

5観点レビュー

Security — 問題なし。タイムアウト延長はセキュリティリスクを生じさせません。

Performance — 許容範囲。GitHub Actions の課金分はランナーが実際に動作した時間に依存するため、タイムアウト上限を引き上げるだけではコストは増加しません。ランナウェイジョブの上限は 30 分で引き続き維持されています。

Quality — 良好。以下の点を確認しました:

  • 2ファイルの変更が一貫している(実ワークフローとテンプレート双方を更新)
  • テンプレートのカスタマイズコメントも値に合わせて更新済み
  • test/template-workflows.test.jstimeout-minutes:存在のみを検証しており(値の検証なし)、テスト破綻なし

Accessibility — 非該当(インフラ変更のため)

AI Residuals — 検出なし


補足観察(ブロッカーではない)

templates/workflows/claude.yml.github/workflows/claude.yml の間には、このPRとは別に以下の事前差分があります(本PRのスコープ外のため指摘のみ):

  • claude-code-action のピンバージョンが異なる(テンプレート: v1.0.89、本リポジトリ: v1 の別ハッシュ)
  • allowedTools の内容が異なる(本リポジトリには gh pr view:* 等が追加されている)

将来的にテンプレートと本リポジトリの設定を同期するタスクとして積んでおくと良いかもしれません。


@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/claude.yml:
- Line 51: The timeout-minutes value in the workflow has been updated to 30, but
the maintenance check in repo-maintenance.md still flags timeouts over 20
minutes as an issue. Update the maintenance check (lines 1448-1460 in
.claude/commands/repo-maintenance.md) to change the threshold from 20 to 30
minutes, and update any associated table entries that document this threshold so
that the documentation reflects the new timeout default and no longer reports
the workflow's 30-minute timeout as non-compliant.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: be8539a2-c36b-4c9d-a6b0-6503c78061b0

📥 Commits

Reviewing files that changed from the base of the PR and between fd366c7 and 9a4cab0.

📒 Files selected for processing (2)
  • .github/workflows/claude.yml
  • templates/workflows/claude.yml

)
runs-on: ubuntu-latest
timeout-minutes: 20
timeout-minutes: 30

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Update maintenance checks/docs to match the new timeout default.

At Line 51, timeout-minutes is now 30, but .claude/commands/repo-maintenance.md (Lines 1448-1460) still flags any timeout over 20 as an issue. This creates a cross-file contract break where valid config is reported as non-compliant.

Please update the maintenance threshold/recommendation (and its table entry) to keep automation and docs aligned with this new default.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/claude.yml at line 51, The timeout-minutes value in the
workflow has been updated to 30, but the maintenance check in
repo-maintenance.md still flags timeouts over 20 minutes as an issue. Update the
maintenance check (lines 1448-1460 in .claude/commands/repo-maintenance.md) to
change the threshold from 20 to 30 minutes, and update any associated table
entries that document this threshold so that the documentation reflects the new
timeout default and no longer reports the workflow's 30-minute timeout as
non-compliant.

@keito4 keito4 self-assigned this Jun 16, 2026
@keito4
keito4 merged commit 1b58f09 into main Jun 16, 2026
16 checks passed
@keito4
keito4 deleted the ci/claude-timeout-30 branch June 16, 2026 09:19
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.116.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released リリース済み label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released リリース済み

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant