ci: Claude Code テンプレートの timeout を 30 分に延長 - #831
Conversation
配布テンプレートと config 自身のワークフローを更新。20分上限で 実装途中にキャンセルされるケースがあったため。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe ChangesClaude Job Timeout Increase
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @keito4's task in 1m 9s —— View job コードレビュー結果
総評承認(APPROVE) — 変更は明確な動機に基づいており、影響範囲も限定的です。 変更内容の確認
5観点レビューSecurity — 問題なし。タイムアウト延長はセキュリティリスクを生じさせません。 Performance — 許容範囲。GitHub Actions の課金分はランナーが実際に動作した時間に依存するため、タイムアウト上限を引き上げるだけではコストは増加しません。ランナウェイジョブの上限は 30 分で引き続き維持されています。 Quality — 良好。以下の点を確認しました:
Accessibility — 非該当(インフラ変更のため) AI Residuals — 検出なし 補足観察(ブロッカーではない)
将来的にテンプレートと本リポジトリの設定を同期するタスクとして積んでおくと良いかもしれません。 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/claude.yml:
- Line 51: The timeout-minutes value in the workflow has been updated to 30, but
the maintenance check in repo-maintenance.md still flags timeouts over 20
minutes as an issue. Update the maintenance check (lines 1448-1460 in
.claude/commands/repo-maintenance.md) to change the threshold from 20 to 30
minutes, and update any associated table entries that document this threshold so
that the documentation reflects the new timeout default and no longer reports
the workflow's 30-minute timeout as non-compliant.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: be8539a2-c36b-4c9d-a6b0-6503c78061b0
📒 Files selected for processing (2)
.github/workflows/claude.ymltemplates/workflows/claude.yml
| ) | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| timeout-minutes: 30 |
There was a problem hiding this comment.
Update maintenance checks/docs to match the new timeout default.
At Line 51, timeout-minutes is now 30, but .claude/commands/repo-maintenance.md (Lines 1448-1460) still flags any timeout over 20 as an issue. This creates a cross-file contract break where valid config is reported as non-compliant.
Please update the maintenance threshold/recommendation (and its table entry) to keep automation and docs aligned with this new default.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/claude.yml at line 51, The timeout-minutes value in the
workflow has been updated to 30, but the maintenance check in
repo-maintenance.md still flags timeouts over 20 minutes as an issue. Update the
maintenance check (lines 1448-1460 in .claude/commands/repo-maintenance.md) to
change the threshold from 20 to 30 minutes, and update any associated table
entries that document this threshold so that the documentation reflects the new
timeout default and no longer reports the workflow's 30-minute timeout as
non-compliant.
|
🎉 This PR is included in version 1.116.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Why
配布先リポジトリ(Elu-co-jp/job_description #754)で
@claude実行が 20 分上限に達し、調査完了後の実装〜PR作成途中でキャンセルされた。提案テンプレート側のデフォルトも引き上げ、配布先で同じ詰まりが起きにくくする。What
templates/workflows/claude.yml:timeout-minutes: 20→30、カスタマイズ説明コメントのデフォルト: 20分→30分.github/workflows/claude.yml(config 自身):timeout-minutes: 20→30How
ランナウェイ防止の上限は維持しつつ、コスト増を抑えた穏当な 30 分に設定。
test/template-workflows.test.jsはtimeout-minutes:の存在のみ検証するため値変更による破綻なし。Risk
低。
🤖 Generated with Claude Code
Summary by CodeRabbit