chore: harvest stable doc domains and align codex/gemini CLI allows - #793
Conversation
直近 active リポ走査で繰り返し参照されていた安定ドキュメントドメインと、 config が公式採用済みの codex/gemini レビュー skill 用 CLI 許可を共有 settings.json に取り込み、devcontainer 設定とのドリフトも解消。 ## settings.json - WebFetch: registry.terraform.io / pub.dev / docs.doppler.com / services.gradle.org(モバイル/IaC/secret ツールチェーンの公式doc先) - Bash: codex / gemini / devcontainer (codex-review / gemini-review skill を公式採用済みだが allow が local 止まりだった。devcontainer 設定には既に存在しており parity を回復) ## devcontainer/claude-settings.json - WebFetch ドメインが skills.sh 以降未追従だったため上記5件を追加し settings.json と整合 いずれも読み取り/参照系で副作用なし。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR expands Claude's external access permissions across two configuration files by allowlisting additional domains for web requests and new command patterns for Bash execution. The changes enable new tool integrations for Terraform, Dart, Doppler, Gradle, and specialized Claude commands. ChangesClaude Permissions Expansion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @keito4's task in 1m 5s —— View job コードレビュー結果
総評: ✅ APPROVE変更はすべて読み取り/参照系の allow 追加のみ。deny/ask ポリシーは無変更。セキュリティリスクは低く、目的(parity 回復)に対して正確に実装されています。 5観点レビュー
個別確認
Recommendation(verdict への影響なし)1. PR 説明では「公式 doc 先」と記述されていますが、 2. devcontainer 側に残る未追従エントリ parity の完全化を目指すなら、 今回の PR スコープ外のため必須ではありませんが、次回の parity 整合時に検討ください。 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/settings.json:
- Around line 25-28: Replace the over-broad Gradle distribution host entry
"WebFetch(domain:services.gradle.org)" with the documentation host
"WebFetch(domain:docs.gradle.org)"; update the JSON entry where
"WebFetch(domain:services.gradle.org)" appears (and the mirrored entry in the
devcontainer settings if present) so the allowlist targets docs.gradle.org
instead of services.gradle.org to limit access to the user manual rather than
distribution endpoints.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fbc66ff7-2e87-4a44-b18d-387c46e68760
📒 Files selected for processing (2)
.claude/settings.json.devcontainer/claude-settings.json
| "WebFetch(domain:registry.terraform.io)", | ||
| "WebFetch(domain:pub.dev)", | ||
| "WebFetch(domain:docs.doppler.com)", | ||
| "WebFetch(domain:services.gradle.org)", |
There was a problem hiding this comment.
Use the Gradle docs host here, not the distribution service.
The PR frames these additions as stable documentation domains, but services.gradle.org is Gradle’s distributions/version endpoint, while the user manual is hosted on docs.gradle.org. That broadens WebFetch beyond documentation content, and the mirrored entry in .devcontainer/claude-settings.json repeats the same over-permissioning. Consider allowlisting WebFetch(domain:docs.gradle.org) instead. (services.gradle.org)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/settings.json around lines 25 - 28, Replace the over-broad Gradle
distribution host entry "WebFetch(domain:services.gradle.org)" with the
documentation host "WebFetch(domain:docs.gradle.org)"; update the JSON entry
where "WebFetch(domain:services.gradle.org)" appears (and the mirrored entry in
the devcontainer settings if present) so the allowlist targets docs.gradle.org
instead of services.gradle.org to limit access to the user manual rather than
distribution endpoints.
|
🎉 This PR is included in version 1.114.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Why
直近 active リポ走査で繰り返し参照されていた安定ドキュメントドメインと、config が公式採用済み(codex-review / gemini-review skill)の CLI 許可が共有
settings.jsonに取り込まれておらず、.devcontainer設定とのドリフトも生じていた。What
.claude/settings.jsonregistry.terraform.io/pub.dev/docs.doppler.com/services.gradle.org(モバイル・IaC・secret ツールチェーンの公式 doc 先)codex/gemini/devcontainer— codex/gemini レビュー skill を公式採用済みなのに allow が local 止まりだった。.devcontainer/claude-settings.jsonには既に存在しており parity を回復.devcontainer/claude-settings.jsonskills.sh以降未追従だったため上記5件を追加しsettings.jsonと整合Risk
低。すべて読み取り/参照系の allow 追加のみ。deny/ask ポリシーは無変更。
🤖 Generated with Claude Code
Summary by CodeRabbit