docs: tool-catalog.md のバージョン番号重複を削除 - #696
Conversation
`npm/global.json` / `package.json` をソース・オブ・トゥルースとし、 docs では `see global.json` または該当ファイルへのリンクで参照する。 これにより毎回の dependency update 時に tool-catalog.md を手動同期する 必要がなくなる（DRY 原則）。バージョン値が知りたい場合は同ファイルを参照。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe tool catalog documentation replaces hardcoded version entries with references to source files ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @keito4's task in 1m 29s —— View job PR レビュー完了
総評DRY 原則に従ってバージョン番号の重複を排除する、意図が明確でスコープも適切な変更です。 Verdict: ✅ APPROVE（下記はすべて minor / recommendation レベル） 指摘事項[minor] セクション 2.1〜2.3 の
|
| 箇所 | 行 | 値 |
|---|---|---|
| Node.js | docs/tool-catalog.md:31 |
24.14.1 |
| pnpm | docs/tool-catalog.md:33 |
10.33.0 |
| Claude Code | docs/tool-catalog.md:43 |
(2.1.92) |
確認事項
- リンクパス
../npm/global.json、../package.jsonがdocs/からの相対パスとして正しいことを確認 ✅ npm/global.jsonにvercel,n8n,pm2,difit,@antfu/ni,@commitlint/*,mcp-remote,n8n-mcp-serverが存在することを確認 ✅- Test plan（lint / test / format）がすべて通過していることをPR本文で確認 ✅
|
(aside) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aecee8073c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - `mcp-remote` — MCP リモート接続 | ||
| - `@leonardsellem/n8n-mcp-server` — n8n MCP サーバー | ||
|
|
||
| ### 2.6 Git / CI 関連（Dockerfile 末尾でインストール、バージョンは [`package.json`](../package.json) 参照） |
There was a problem hiding this comment.
The updated 2.6 heading points readers to package.json for version information, but @commitlint/cli and @commitlint/config-conventional are defined there as semver ranges (e.g. ^20.5.x), while the image actually installs pinned versions via npm ci from package-lock.json. In this state, the docs can show an imprecise or wrong effective version after range-only edits, so the source-of-truth note should reference the lockfile (or keep explicit pinned values).
Useful? React with 👍 / 👎.
|
Claude finished @keito4's task in 8m 52s —— View job CI 失敗の調査結果
|
| チェック | 結果 |
|---|---|
| Quality Gate | ✅ SUCCESS |
| GitGuardian Security Checks | ✅ SUCCESS |
| claude-review | ✅ SUCCESS |
| check-ci-status | ✅ SUCCESS |
| dependabot-auto | ✅ SUCCESS |
CI は現在すべて緑です。 ci.yml は markdown のみの変更にはパス不要なため、quality-gate-fallback.yml が Quality Gate を代行し PASS しています。
マージがブロックされている本当の原因
mergeStateStatus: BLOCKED
reviewDecision: REVIEW_REQUIRED
mergeable: MERGEABLE（コンフリクトなし）
CI 失敗ではなく、ブランチ保護の「レビュー必須」ルールによるブロックです。承認済みレビューが 0 件のため、マージできない状態です。
関連情報
PR #695 (fix/quality-gate-fallback-name) が open 中です。ci.yml と quality-gate-fallback.yml が同じ name: CI を持つことで Actions UI 上の混乱を招く問題を修正するものです（workflow 名を CI Fallback に変更）。本 PR #696 のブロックとは無関係ですが、マージ前に #695 のマージを先に済ませると UI がスッキリします。
CI の修正は不要です（すでに全チェック PASS）。マージには人間によるレビュー承認が必要です。
|
(aside) |
|
Claude finished @keito4's task in 7m 10s —— View job 完了
調査結果と対応内容根本原因: 実施した修正:
現在の PR 状態:
CI（GitGuardian 🟢、Quality Gate 実行中）が完了すれば、すべてのチェックが green になる見込みです。 |
…-catalog-no-version-dup
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
docs/tool-catalog.md (3)
29-35: LGTM! DRY improvement successfully implemented.The replacement of hardcoded versions with "see global.json" for npm and corepack correctly references the single source of truth. This eliminates manual synchronization when dependencies are updated.
💡 Optional enhancement: Make "see global.json" clickable for better UX
Consider converting the plain text references into clickable links:
-| npm | see global.json | パッケージマネージャ | -| corepack | see global.json | パッケージマネージャ切替 | +| npm | [see global.json](../npm/global.json) | パッケージマネージャ | +| corepack | [see global.json](../npm/global.json) | パッケージマネージャ切替 |This would allow readers to navigate directly to the source file.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/tool-catalog.md` around lines 29 - 35, Replace the plain "see global.json" text for the npm and corepack rows in the tools table with a clickable Markdown link to the repository's global.json (e.g., [see global.json](./global.json)), so update the npm and corepack table cells in docs/tool-catalog.md to use a Markdown link pointing to the global.json file to improve UX and direct readers to the single source of truth.
41-47: LGTM! Consistent DRY implementation for AI CLI tools.The changes correctly reference
global.jsonfor npm-managed AI CLI tools while preserving version information for tools installed via other methods (native installer, curl).💡 Optional enhancement: Make references clickable
-| Codex (`@openai/codex`) | see global.json | OpenAI Codex CLI | -| Gemini CLI (`@google/gemini-cli`) | see global.json | Google Gemini CLI | -| Happy Coder | see global.json | AI コーディング | +| Codex (`@openai/codex`) | [see global.json](../npm/global.json) | OpenAI Codex CLI | +| Gemini CLI (`@google/gemini-cli`) | [see global.json](../npm/global.json) | Google Gemini CLI | +| Happy Coder | [see global.json](../npm/global.json) | AI コーディング |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/tool-catalog.md` around lines 41 - 47, Update the table entries that currently show "see global.json" so they link to the actual global.json file (make the text a clickable Markdown link) for the Codex (`@openai/codex`), Gemini CLI (`@google/gemini-cli`) and Happy Coder rows; preserve the display text while wrapping it in a relative link to global.json and ensure Markdown table alignment remains intact.
62-74: LGTM! Selective version reference replacement is appropriate.The changes correctly identify and update only the npm-managed utilities (Vercel CLI, n8n, pm2, difit,
@antfu/ni) to referenceglobal.json, while preserving explicit version information for tools managed via apt, pnpm global, or on-demand installation.💡 Optional enhancement: Add clickable links
-| Vercel CLI | see global.json | Vercel デプロイ | -| n8n | see global.json | ワークフロー自動化 | -| pm2 | see global.json | プロセスマネージャ | -| difit | see global.json | AI diff レビューツール | -| `@antfu/ni` | see global.json | パッケージマネージャ抽象化 CLI | +| Vercel CLI | [see global.json](../npm/global.json) | Vercel デプロイ | +| n8n | [see global.json](../npm/global.json) | ワークフロー自動化 | +| pm2 | [see global.json](../npm/global.json) | プロセスマネージャ | +| difit | [see global.json](../npm/global.json) | AI diff レビューツール | +| `@antfu/ni` | [see global.json](../npm/global.json) | パッケージマネージャ抽象化 CLI |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/tool-catalog.md` around lines 62 - 74, The table update is good; as an optional enhancement, convert the tool names for Vercel CLI, n8n, pm2, difit and `@antfu/ni` into clickable Markdown links to their official docs/repos so readers can quickly access installation/usage info; edit the rows in docs/tool-catalog.md replacing plain names with [Vercel CLI](...), [n8n](...), [pm2](...), [difit](...), and [`@antfu/ni`](...) while preserving the "see global.json" version cells and keeping existing entries for apt/pnpm/on-demand tools unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/tool-catalog.md`:
- Around line 29-35: Replace the plain "see global.json" text for the npm and
corepack rows in the tools table with a clickable Markdown link to the
repository's global.json (e.g., [see global.json](./global.json)), so update the
npm and corepack table cells in docs/tool-catalog.md to use a Markdown link
pointing to the global.json file to improve UX and direct readers to the single
source of truth.
- Around line 41-47: Update the table entries that currently show "see
global.json" so they link to the actual global.json file (make the text a
clickable Markdown link) for the Codex (`@openai/codex`), Gemini CLI
(`@google/gemini-cli`) and Happy Coder rows; preserve the display text while
wrapping it in a relative link to global.json and ensure Markdown table
alignment remains intact.
- Around line 62-74: The table update is good; as an optional enhancement,
convert the tool names for Vercel CLI, n8n, pm2, difit and `@antfu/ni` into
clickable Markdown links to their official docs/repos so readers can quickly
access installation/usage info; edit the rows in docs/tool-catalog.md replacing
plain names with [Vercel CLI](...), [n8n](...), [pm2](...), [difit](...), and
[`@antfu/ni`](...) while preserving the "see global.json" version cells and
keeping existing entries for apt/pnpm/on-demand tools unchanged.
|
🎉 This PR is included in version 1.111.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
Summary
docs/tool-catalog.mdからnpm/global.json/package.json由来のバージョン番号を削除し、各ファイルへのリンク参照に置換。dependency 更新時の手動同期が不要になる（DRY）。変更内容
npm,corepackのバージョンセル →see global.jsonCodex,Gemini CLI,Happy Coder→see global.jsonVercel CLI,n8n,pm2,difit,@antfu/ni→see global.jsonnpm/global.jsonリンクnpm/global.jsonリンクpackage.jsonリンクTest plan
npm run lint緑npm test95 件パスnpm run format:check緑🤖 Generated with Claude Code
Summary by CodeRabbit