Skip to content

fix: hooks スクリプト未存在時の graceful fallback #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keito4 merged 1 commit into from
Mar 21, 2026
Merged

fix: hooks スクリプト未存在時の graceful fallback #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/block_git_no_verify.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/block_git_no_verify.py ] && python3 .claude/hooks/block_git_no_verify.py || echo \"[hooks] .claude/hooks/block_git_no_verify.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve hook failure exit codes when adding fallback

The new A && B || echo ... pattern turns real hook failures into success: when python3 .claude/hooks/block_git_no_verify.py exists but exits non-zero (e.g., it intentionally returns 2 to block forbidden commands), the || echo ... branch runs and the overall shell command exits 0, so Claude no longer blocks the action. This regresses the enforcement behavior documented for these hooks and applies to each similarly updated command in this file.

Useful? React with 👍 / 👎.

}
]
},
Expand All @@ -182,7 +182,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/pre_git_quality_gates.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/pre_git_quality_gates.py ] && python3 .claude/hooks/pre_git_quality_gates.py || echo \"[hooks] .claude/hooks/pre_git_quality_gates.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"
}
]
},
Expand All @@ -191,7 +191,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/block_config_edit.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/block_config_edit.py ] && python3 .claude/hooks/block_config_edit.py || echo \"[hooks] .claude/hooks/block_config_edit.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"
}
]
},
Expand All @@ -200,7 +200,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/pre_exit_plan_ai_review.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/pre_exit_plan_ai_review.py ] && python3 .claude/hooks/pre_exit_plan_ai_review.py || echo \"[hooks] .claude/hooks/pre_exit_plan_ai_review.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"
}
]
}
Expand All @@ -211,7 +211,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/post_edit_auto_lint.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/post_edit_auto_lint.py ] && python3 .claude/hooks/post_edit_auto_lint.py || echo \"[hooks] .claude/hooks/post_edit_auto_lint.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"
}
]
},
Expand All @@ -220,7 +220,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/post_git_push_ci.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/post_git_push_ci.py ] && python3 .claude/hooks/post_git_push_ci.py || echo \"[hooks] .claude/hooks/post_git_push_ci.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"
}
]
},
Expand All @@ -229,7 +229,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/post_pr_ai_review.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/post_pr_ai_review.py ] && python3 .claude/hooks/post_pr_ai_review.py || echo \"[hooks] .claude/hooks/post_pr_ai_review.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"
}
]
},
Expand All @@ -238,7 +238,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/post_pr_ci_watch.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/post_pr_ci_watch.py ] && python3 .claude/hooks/post_pr_ci_watch.py || echo \"[hooks] .claude/hooks/post_pr_ci_watch.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"
}
]
}
Expand All @@ -249,7 +249,7 @@
"hooks": [
{
"type": "command",
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && python3 .claude/hooks/stop_test_verification.py'"
"command": "bash -c 'cd \"$(git rev-parse --show-toplevel 2>/dev/null || echo .)\" && { [ -f .claude/hooks/stop_test_verification.py ] && python3 .claude/hooks/stop_test_verification.py || echo \"[hooks] .claude/hooks/stop_test_verification.py not found. Run /repo-maintenance to set up quality hooks.\"; }'"
}
]
}
Expand Down
Loading