Repository navigation
fix: npm warnings and add BATS to Dockerfile #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,19 @@ | ||
| # pnpm security settings | ||
| # Strict peer dependency resolution - fail on conflicts | ||
| strict-peer-dependencies=true | ||
|
|
||
| # Auto-install missing peer dependencies | ||
| auto-install-peers=true | ||
|
|
||
| # npm security settings | ||
| # Run security audit on install | ||
| audit=true | ||
| audit-level=moderate | ||
|
|
||
| # ============================================================ | ||
| # pnpm-specific settings (ignored by npm, used when pnpm is detected) | ||
| # ============================================================ | ||
| # Strict peer dependency resolution - fail on conflicts | ||
| # strict-peer-dependencies=true | ||
|
|
||
| # Auto-install missing peer dependencies | ||
| # auto-install-peers=true | ||
|
|
||
| # Prevent phantom dependencies (packages hoisting to root node_modules) | ||
| shamefully-hoist=false | ||
| # shamefully-hoist=false | ||
|
|
||
| # Use content-addressable storage (pnpm default - integrity verification) | ||
| verify-store-integrity=true | ||
| # verify-store-integrity=true | ||
|
Comment on lines
+6
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: pnpm’s recommended way to avoid npm warnings about pnpm-only config keys is to move those settings out of the project Example # pnpm-workspace.yaml
strictPeerDependencies: true
autoInstallPeers: true
shamefullyHoist: true
verifyStoreIntegrity: trueThese exact settings are documented as supported 🏁 Script executed: # Check if pnpm-workspace.yaml exists
fd -t f "pnpm-workspace.yaml" .Repository: keito4/config Length of output: 78 🏁 Script executed: # Check the .npmrc file to see the exact settings
cat -n .npmrcRepository: keito4/config Length of output: 833 🏁 Script executed: # Check the pnpm-workspace.yaml file
cat -n pnpm-workspace.yamlRepository: keito4/config Length of output: 381 Migrate pnpm safeguards from Commenting out Lines 10, 13, 16, and 19 disables pnpm's peer-dependency, hoisting, and store-integrity checks. The repo still provisions pnpm in Rather than comment them out, move these settings to
This avoids npm warnings while keeping pnpm safeguards active across the repo. 🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting out
strict-peer-dependencies(and related pnpm flags) removes those protections for pnpm as well, because commented.npmrcentries are never read by any package manager. In this repo we still execute pnpm commands (for example in.devcontainer/Dockerfile), so peer dependency conflicts that were previously blocked can now be silently accepted during dependency resolution, which weakens the intended supply-chain/consistency guardrails.Useful? React with 👍 / 👎.