-
Notifications
You must be signed in to change notification settings - Fork 0
feat: @antfu/ni をグローバルパッケージに追加し ni エイリアスを設定 #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1bb23d5
45698ed
6d2e6a4
ddb2db4
6355a25
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # pnpm security settings | ||
| # Strict peer dependency resolution - fail on conflicts | ||
| strict-peer-dependencies=true | ||
|
|
||
| # Auto-install missing peer dependencies | ||
| auto-install-peers=true | ||
|
|
||
| # Run security audit on install | ||
| audit=true | ||
| audit-level=moderate | ||
|
|
||
| # Prevent phantom dependencies (packages hoisting to root node_modules) | ||
| shamefully-hoist=false | ||
|
|
||
| # Use content-addressable storage (pnpm default - integrity verification) | ||
| verify-store-integrity=true |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -123,7 +123,13 @@ case ":$PATH:" in | |||||
| *":$PNPM_HOME:"*) ;; | ||||||
| *) export PATH="$PNPM_HOME:$PATH" ;; | ||||||
| esac | ||||||
| # pnpm end# Added by Windsurf | ||||||
| # pnpm end | ||||||
|
|
||||||
| # ni - package manager command unifier (@antfu/ni) | ||||||
| alias nrd="nr dev" | ||||||
| alias nrb="nr build" | ||||||
| alias nrs="nr start" | ||||||
| alias nrp="nr preview"# Added by Windsurf | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n dot/.zshrc | sed -n '125,140p'Repository: keito4/config Length of output: 594 🏁 Script executed: # Test shell alias parsing with and without space before inline comment
bash -c 'alias nrp="nr preview"# Added by Windsurf 2>/dev/null; alias nrp' 2>&1 || true
echo "---"
bash -c 'alias nrp2="nr preview" # Added by Windsurf 2>/dev/null; alias nrp2' 2>&1 || trueRepository: keito4/config Length of output: 84 🏁 Script executed: # Verify the exact patterns mentioned in the review
rg -nP '^\s*alias\s+nrp="nr preview"#' dot/.zshrc dot/.zshrc.devcontainer 2>/dev/null || echo "No matches found"
echo "---"
rg -nP '^\s*alias\s+nr[dbsp]=' dot/.zshrc dot/.zshrc.devcontainer 2>/dev/null | head -20Repository: keito4/config Length of output: 472 Fix inline comment spacing in alias definition. Line 132 has Suggested fix-alias nrp="nr preview"# Added by Windsurf
+alias nrp="nr preview" # Added by WindsurfThis causes the alias to expand to 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| export PATH="$HOME/.codeium/windsurf/bin:$PATH" | ||||||
|
|
||||||
| ### MANAGED BY RANCHER DESKTOP START (DO NOT EDIT) | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -86,4 +86,10 @@ setopt COMPLETE_IN_WORD | |||||||||||||||||||||||
| setopt NO_BEEP | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| # Set default editor | ||||||||||||||||||||||||
| export EDITOR='vim' | ||||||||||||||||||||||||
| export EDITOR='vim' | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| # ni - package manager command unifier (@antfu/ni) | ||||||||||||||||||||||||
| alias nrd="nr dev" | ||||||||||||||||||||||||
| alias nrb="nr build" | ||||||||||||||||||||||||
| alias nrs="nr start" | ||||||||||||||||||||||||
| alias nrp="nr preview" | ||||||||||||||||||||||||
|
Comment on lines
+91
to
+95
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aliases look correct; add trailing newline for POSIX compliance. The ni aliases are properly defined. However, the file is missing a trailing newline at the end (Line 95), which can cause issues with POSIX tools and some editors. 🔧 Add trailing newline # ni - package manager command unifier (`@antfu/ni`)
alias nrd="nr dev"
alias nrb="nr build"
alias nrs="nr start"
alias nrp="nr preview"
+📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,10 @@ | |
| "version": "0.34.6", | ||
| "overridden": false | ||
| }, | ||
| "@antfu/ni": { | ||
| "version": "28.2.0", | ||
| "overridden": false | ||
|
Comment on lines
+56
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Adding Useful? React with 👍 / 👎. |
||
| }, | ||
| "difit": { | ||
| "version": "3.1.12", | ||
| "overridden": false | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # pnpm workspace configuration | ||
| # https://pnpm.io/pnpm-workspace_yaml | ||
|
|
||
| # supply chain attack 対策: 公開から 2 日未満のパッケージをインストール禁止 | ||
| # pnpm v10.16.0+ でサポート | ||
| # 単位: 分(2880 = 2 days) | ||
| minimumReleaseAge: 2880 | ||
|
|
||
| # 除外パッケージ(公式・信頼できるリリースサイクルが速いもの) | ||
| minimumReleaseAgeExclude: [] | ||
|
Comment on lines
+1
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result:
What to do
Sources 🌐 Web query:
💡 Result:
Example ( packages:
- "packages/*"
minimumReleaseAge: 1440 # minutes (24h)
minimumReleaseAgeExclude:
- react
- webpack
- "@myorg/*"Sources: pnpm settings documentation (workspace file) describing References Citations: 🌐 Web query:
💡 Result: If your repo has only one package (the root If you still want a Minimal “single-package repo”
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
nrpalias line appends# Added by Windsurfdirectly after the closing quote, so#is parsed as part of the argument (not a comment) and the trailing words are treated as extraaliasoperands when the file is sourced. This leavesnrpmapped incorrectly (e.g. ending with#) and can emit startup errors, so the new shortcut does not reliably work.Useful? React with 👍 / 👎.