refactor: remove unnecessary code references - #53
Conversation
- Remove reference to non-existent .releaserc.json from package.json - Remove GitHub Actions commands from Makefile (act-list, act-run, etc.) - Remove references to non-existent dotfiles in import.sh and export.sh - Remove legacy .env.secret.template references from credentials.sh Co-authored-by: keito4 <keito4@users.noreply.github.com>
WalkthroughThis update removes obsolete or unnecessary code from the repository. Targets and logic related to local GitHub Actions workflow execution, legacy credential templates, certain dotfile exports/imports, and release configuration are deleted from their respective scripts and configuration files. The changes streamline credential handling, shell config management, and build tooling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Makefile (1)
1-1: Add the commonly expectedall,clean, andtestphony targetsStatic-analysis (
checkmake) flags their absence. Even if you intentionally removed other targets, having minimalist stubs avoids CI warnings and makes the Makefile UX predictable:.PHONY: all clean test \ version-patch version-minor version-major version-dry-run \ credentials clean-credentials list-credentials \ brew-leaves brew-categorized brew-generate brew-deps brew-uses all: ## Default target – show help @$(MAKE) -q help || true clean: ## Remove generated artifacts @git clean -fdX test: ## Run project tests @echo "No test harness defined"These stubs satisfy tooling and give contributors clear extension points without re-introducing removed functionality.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
Makefile(1 hunks)package.json(0 hunks)script/credentials.sh(0 hunks)script/export.sh(1 hunks)script/import.sh(0 hunks)
💤 Files with no reviewable changes (3)
- package.json
- script/import.sh
- script/credentials.sh
🧰 Additional context used
🧬 Code Graph Analysis (1)
script/export.sh (1)
script/commit_changes.sh (1)
check_and_commit(5-22)
🪛 checkmake (0.2.2)
Makefile
[warning] 1-1: Missing required phony target "all"
(minphony)
[warning] 1-1: Missing required phony target "clean"
(minphony)
[warning] 1-1: Missing required phony target "test"
(minphony)
| # Ensure REPO_PATH exists | ||
| REPO_PATH="${REPO_PATH:-$(pwd)}" | ||
| mkdir -p "$REPO_PATH/brew" "$REPO_PATH/vscode" "$REPO_PATH/git" "$REPO_PATH/dot" "$REPO_PATH/npm" "$REPO_PATH/.zsh" | ||
| mkdir -p "$REPO_PATH/brew" "$REPO_PATH/vscode" "$REPO_PATH/git" "$REPO_PATH/npm" "$REPO_PATH/.zsh" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove redundant .zsh directory creation or adjust the copy target
mkdir -p "$REPO_PATH/.zsh" (line 7) creates the directory, and later cp -r -f ~/.zsh "$REPO_PATH" (line 46) copies the same directory into the repo root.
With the directory already present, cp will attempt to merge files into an existing path. On some cp implementations this is harmless, but on others it triggers the “cannot copy a directory into itself” guard, which – combined with set -e – aborts the script.
A minimal, safe fix is to copy directly into the path you just created and drop the redundant mkdir:
- mkdir -p "$REPO_PATH/brew" "$REPO_PATH/vscode" "$REPO_PATH/git" "$REPO_PATH/npm" "$REPO_PATH/.zsh"
+ mkdir -p "$REPO_PATH/brew" "$REPO_PATH/vscode" "$REPO_PATH/git" "$REPO_PATH/npm"- [[ -d ~/.zsh ]] && cp -r -f ~/.zsh "$REPO_PATH"
+ [[ -d ~/.zsh ]] && cp -r -f ~/.zsh "$REPO_PATH/.zsh"This keeps the behaviour unchanged while avoiding a potential hard-to-trace failure and one unnecessary directory creation.
Also applies to: 46-46
🤖 Prompt for AI Agents
In script/export.sh at line 7, remove the creation of the "$REPO_PATH/.zsh"
directory since the script later copies the entire ~/.zsh directory into
"$REPO_PATH" at line 46. This avoids the risk of cp trying to merge into an
existing directory and causing a failure. Instead, either remove the mkdir for
.zsh or adjust the cp command to copy directly into the already created
directory, ensuring no redundant directory creation or conflicting copy targets.
1 participant
Removes unnecessary code references and unused configurations from the repository.
Changes
Closes #52
Generated with Claude Code
Summary by CodeRabbit