fix: CLAUDE.md symlink の prettier 警告を解消 - #493
Conversation
core.symlinks=false 環境で CLAUDE.md がテキストファイルとして 扱われるため prettier チェックが失敗する問題を .prettierignore で回避 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebdeb3d5c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .agents/skills/ | ||
|
|
||
| # Symlinks (git core.symlinks=false stores as text files) | ||
| CLAUDE.md |
There was a problem hiding this comment.
Limit CLAUDE.md ignore pattern to repository root
The new CLAUDE.md entry uses gitignore-style matching, so it ignores every file named CLAUDE.md (including the real markdown file at .claude/CLAUDE.md), not just the root symlink this change is trying to suppress. As a result, format:check stops validating non-symlink CLAUDE docs and formatting regressions there can slip through undetected. Use a root-anchored pattern (for example /CLAUDE.md) to exclude only the symlink case.
Useful? React with 👍 / 👎.
レビュー変更の概要core.symlinks=false 環境でシンボリックリンク CLAUDE.md がテキストファイルとして扱われ prettier チェックが失敗する問題を .prettierignore への追加で解消しようとするアプローチは 正しい方向性 です。 問題点既存コメント(P2)で指摘されているとおり、パターンのルートアンカーが欠落しています。 gitignore 形式のパターンでは、アンカーなしの
修正案-CLAUDE.md
+/CLAUDE.mdルートアンカー(先頭に その他の観点
結論パターンを |
|
🎉 This PR is included in version 1.81.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
CLAUDE.mdが AGENTS.md への symlink に変更されたが、core.symlinks=false環境ではテキストファイルとして扱われ prettier チェックが失敗する問題を修正.prettierignoreにCLAUDE.mdを追加して警告を解消Test plan
npm run format:check通過npm run lint通過npm test通過(101 tests passed)🤖 Generated with Claude Code
Summary by CodeRabbit