fix: /doctor 警告解消・未使用MCP設定削除 - #492
Conversation
📝 WalkthroughWalkthroughThis PR removes o3 and Linear MCP server integrations from the project. Changes span configuration files (deletion of server definitions and permissions), DevContainer settings (removal of allowed commands), and documentation (complete removal of o3 MCP and Linear sections). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
(aside) |
|
Claude finished @keito4's task in 9m 1s —— View job コンフリクト解消完了 ✅
実施内容コンフリクト原因: 解消方法:
最終状態: 変更ファイル(8件): |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/mcp-servers-guide.md (1)
167-171: Direnv example repeatsSUPABASE_URLalready shown in example 1.Both
SUPABASE_URLandSUPABASE_KEYare required (per the Supabase section), so the.envrcsnippet would be more useful showing both, or at leastSUPABASE_KEY(the one not yet covered by a shell example).📝 Proposed update to the direnv example
3. **direnvを使用** ```bash # .envrc - export SUPABASE_URL="https://xxx.supabase.co" + export SUPABASE_URL="https://xxx.supabase.co" + export SUPABASE_KEY="your-supabase-key" ```🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/mcp-servers-guide.md` around lines 167 - 171, Update the .envrc direnv example to include the missing SUPABASE_KEY environment variable (in addition to SUPABASE_URL) so both required vars from the Supabase section are shown; modify the .envrc snippet to export SUPABASE_KEY along with SUPABASE_URL to demonstrate the complete required configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/mcp-servers-guide.md`:
- Around line 167-171: Update the .envrc direnv example to include the missing
SUPABASE_KEY environment variable (in addition to SUPABASE_URL) so both required
vars from the Supabase section are shown; modify the .envrc snippet to export
SUPABASE_KEY along with SUPABASE_URL to demonstrate the complete required
configuration.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98f590796d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ```bash | ||
| export LINEAR_API_KEY="lin_api_xxx" | ||
| export SUPABASE_URL="https://xxx.supabase.co" |
There was a problem hiding this comment.
/doctor で検出された警告を解消するため、環境変数未設定の o3 (OPENAI_API_KEY) と linear (LINEAR_API_KEY) を全設定ファイル およびドキュメントから削除。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
98f5907 to
db650b8
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/mcp-servers-guide.md (1)
155-171: Thedirenvexample is incomplete — both required Supabase env vars should be shown together.Line 170 shows only
SUPABASE_URLin the.envrcsnippet, while the Supabase MCP server definition (lines 112-114) requires bothSUPABASE_URLandSUPABASE_KEY. A user who copies this.envrcexample verbatim will still get auth failures. The direnv block is the most natural place to show a full, copy-pasteable configuration; showing only one variable defeats that purpose.Similarly, the shell export at line 158 only demonstrates
SUPABASE_URL. Showing a single variable per method means each example is illustrative of a pattern rather than actionable, which is a documentation gap.📝 Suggested documentation improvement
1. **シェルで直接設定** ```bash export SUPABASE_URL="https://xxx.supabase.co" + export SUPABASE_KEY="your-anon-or-service-role-key" ``` 2. **1Passwordなどのシークレット管理ツール** ```bash export SUPABASE_KEY=$(op read "op://vault/supabase/api-key") + export SUPABASE_URL=$(op read "op://vault/supabase/url") ``` 3. **direnvを使用** ```bash # .envrc export SUPABASE_URL="https://xxx.supabase.co" + export SUPABASE_KEY="your-anon-or-service-role-key" ```🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/mcp-servers-guide.md` around lines 155 - 171, Update the examples so every environment-setting method exports both required variables (SUPABASE_URL and SUPABASE_KEY): modify the shell example to include export SUPABASE_KEY alongside SUPABASE_URL, change the 1Password example to export both SUPABASE_KEY and SUPABASE_URL (using op read for each), and update the direnv .envrc snippet to show export SUPABASE_URL and export SUPABASE_KEY together so the shown configuration is copy-pasteable and matches the Supabase MCP server requirements.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/mcp-servers-guide.md`:
- Around line 155-171: Update the examples so every environment-setting method
exports both required variables (SUPABASE_URL and SUPABASE_KEY): modify the
shell example to include export SUPABASE_KEY alongside SUPABASE_URL, change the
1Password example to export both SUPABASE_KEY and SUPABASE_URL (using op read
for each), and update the direnv .envrc snippet to show export SUPABASE_URL and
export SUPABASE_KEY together so the shown configuration is copy-pasteable and
matches the Supabase MCP server requirements.
|
🎉 This PR is included in version 1.80.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
/doctorで検出された MCP 設定警告(o3, linear の環境変数未設定)を解消Test plan
npm run format:check通過npm run lint通過npm test通過(101 tests passed)/doctor再実行で MCP 警告が解消されていることを確認🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation