feat: パッケージを最新バージョンに更新 - #463
Conversation
- ESLint 9.39.2 → 10.0.0（@eslint/js 追加） - @commitlint/config-conventional 20.4.0 → 20.4.1 - Claude Code 2.1.33 → 2.1.39（Dockerfile） - @openai/codex 0.92.0 → 0.99.0 - @google/gemini-cli 0.26.0 → 0.28.2 - その他グローバルパッケージ多数更新 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis pull request updates development container and dependency configurations across four files. Version updates include Claude Code installer (2.1.33 → 2.1.39), multiple npm global tools, and ESLint dependencies. DevContainer scripts are refactored to support flexible workspace directory structures using glob patterns. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Review: パッケージ更新✅ 全体評価このPRは主要なツールのバージョン更新を適切に実施しており、CIチェックもほぼ全てパスしています。ESLint 10へのメジャーアップデートが含まれていますが、適切に対応されています。 📋 コード品質とベストプラクティス✅ 良い点:
🔍 潜在的な問題・懸念点
🛡️ セキュリティ考慮事項✅ セキュリティ:
⚡ パフォーマンス考慮事項
🧪 テストカバレッジ✅ 十分:
📝 推奨事項
🎯 結論承認推奨 ✅ このPRは品質基準を満たしており、適切なテストとセキュリティチェックが実施されています。ESLint 10へのメジャーアップデートも適切に対応されています。 上記の推奨事項を確認後、マージして問題ありません。 レビュー完了 - Generated by Claude Code |
- /workspaces/config/ を /workspaces/*/ に変更 - 他のCodespacesリポジトリでも動作するように修正 - restore-cli-auth.sh のフォールバックパスを追加 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.devcontainer/codespaces/devcontainer.json:
- Around line 71-72: The postCreateCommand uses a fragile glob ("cd
/workspaces/*/ && ./script/install-npm-globals.sh") which fails when zero or
multiple dirs match; update postCreateCommand to robustly find a workspace dir
(e.g., iterate over /workspaces/*/ and cd into the first directory that exists
before running ./script/install-npm-globals.sh) and ensure it doesn't cause a
failing build (add a safe fallback like || true if you want to ignore failures).
Do the same defensive change for postStartCommand's cd invocation in the
"/usr/local/script/install-skills.sh; cd /workspaces/*/ &&
./script/restore-cli-auth.sh || true" sequence: iterate to the first matching
directory or check existence before cd, then run ./script/restore-cli-auth.sh,
keeping the existing || true to avoid failing the container start.
| "postCreateCommand": "cd /workspaces/*/ && ./script/install-npm-globals.sh", | ||
| "postStartCommand": "/usr/local/script/install-skills.sh; cd /workspaces/*/ && ./script/restore-cli-auth.sh || true" |
There was a problem hiding this comment.
cd /workspaces/*/ silently fails when the glob matches zero or multiple directories.
Shell glob cd /workspaces/*/ only works when exactly one subdirectory exists. With zero matches, the literal */ path doesn't exist and cd fails; with multiple matches, cd receives multiple arguments and errors out. In both cases, && short-circuits and the script never runs.
Line 71 is particularly risky because there's no || true fallback — postCreateCommand failure could surface as a container build error or silently skip install-npm-globals.sh depending on the shell behavior.
Consider a more robust approach:
Proposed fix
- "postCreateCommand": "cd /workspaces/*/ && ./script/install-npm-globals.sh",
- "postStartCommand": "/usr/local/script/install-skills.sh; cd /workspaces/*/ && ./script/restore-cli-auth.sh || true"
+ "postCreateCommand": "cd /workspaces/$(ls /workspaces/)/ && ./script/install-npm-globals.sh",
+ "postStartCommand": "/usr/local/script/install-skills.sh; cd /workspaces/$(ls /workspaces/)/ && ./script/restore-cli-auth.sh || true"Or, if you want to be defensive about multiple directories:
- "postCreateCommand": "cd /workspaces/*/ && ./script/install-npm-globals.sh",
+ "postCreateCommand": "dir=$(find /workspaces -mindepth 1 -maxdepth 1 -type d | head -1) && cd \"$dir\" && ./script/install-npm-globals.sh",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "postCreateCommand": "cd /workspaces/*/ && ./script/install-npm-globals.sh", | |
| "postStartCommand": "/usr/local/script/install-skills.sh; cd /workspaces/*/ && ./script/restore-cli-auth.sh || true" | |
| "postCreateCommand": "cd /workspaces/$(ls /workspaces/)/ && ./script/install-npm-globals.sh", | |
| "postStartCommand": "/usr/local/script/install-skills.sh; cd /workspaces/$(ls /workspaces/)/ && ./script/restore-cli-auth.sh || true" |
🤖 Prompt for AI Agents
In @.devcontainer/codespaces/devcontainer.json around lines 71 - 72, The
postCreateCommand uses a fragile glob ("cd /workspaces/*/ &&
./script/install-npm-globals.sh") which fails when zero or multiple dirs match;
update postCreateCommand to robustly find a workspace dir (e.g., iterate over
/workspaces/*/ and cd into the first directory that exists before running
./script/install-npm-globals.sh) and ensure it doesn't cause a failing build
(add a safe fallback like || true if you want to ignore failures). Do the same
defensive change for postStartCommand's cd invocation in the
"/usr/local/script/install-skills.sh; cd /workspaces/*/ &&
./script/restore-cli-auth.sh || true" sequence: iterate to the first matching
directory or check existence before cd, then run ./script/restore-cli-auth.sh,
keeping the existing || true to avoid failing the container start.
PR Review - Package Updates概要このPRは複数のパッケージを最新バージョンに更新するものです。全体的に適切な更新ですが、いくつかの重要な点について確認とフォローアップが必要です。 ✅ 良い点
|
|
🎉 This PR is included in version 1.71.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
Summary
@eslint/jsパッケージ追加）@commitlint/config-conventional20.4.0 → 20.4.1@openai/codex0.92.0 → 0.99.0@google/gemini-cli0.26.0 → 0.28.2mcp-remote0.1.37 → 0.1.38n8n2.4.6 → 2.7.4npm11.8.0 → 11.10.0vercel50.8.1 → 50.15.1Test plan
npm run lintパスnpm testパス（101テスト成功）npm audit脆弱性なし🤖 Generated with Claude Code
Summary by CodeRabbit
Chores