Repository navigation
feat: fix LSP configuration for Claude Code integration #310
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| #!/bin/bash | ||
| # Language Server Protocol Setup Script | ||
| # Installs language servers required for Claude Code LSP integration | ||
|
|
||
| set -e | ||
|
There was a problem hiding this comment. Consider propagating failure status via exit code. The script uses 🔎 Proposed fix to propagate error status if [ $errors -eq 0 ]; then
echo "=== All Language Servers installed successfully ==="
else
echo "=== Warning: $errors language server(s) missing ==="
fi
-exit 0
+exit $errorsIf a non-zero exit would break the DevContainer build, consider making it configurable or at least documenting the intentional silent failure behavior. Also applies to: 53-59 🤖 Prompt for AI Agents |
||
|
|
||
| echo "=== Installing Language Servers ===" | ||
|
|
||
| # Check if npm is available | ||
| if ! command -v npm &> /dev/null; then | ||
| echo "Error: npm is not installed" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Define language servers to install | ||
| LANGUAGE_SERVERS=( | ||
| "typescript" | ||
| "typescript-language-server" | ||
| "bash-language-server" | ||
| "vscode-langservers-extracted" | ||
| "yaml-language-server" | ||
| ) | ||
|
|
||
| # Install language servers globally | ||
| echo "Installing language servers globally..." | ||
| npm install -g "${LANGUAGE_SERVERS[@]}" | ||
|
|
||
| # Verify installation | ||
| echo "" | ||
| echo "=== Verifying Language Server Installation ===" | ||
|
|
||
| verify_command() { | ||
| local cmd=$1 | ||
| local name=$2 | ||
| if command -v "$cmd" &> /dev/null; then | ||
| version=$($cmd --version 2>/dev/null | head -1 || echo "installed") | ||
| echo "[OK] $name: $version" | ||
| return 0 | ||
| else | ||
| echo "[MISSING] $name" | ||
| return 1 | ||
| fi | ||
| } | ||
|
|
||
| errors=0 | ||
| verify_command "typescript-language-server" "TypeScript LSP" || ((errors++)) | ||
| verify_command "bash-language-server" "Bash LSP" || ((errors++)) | ||
| verify_command "yaml-language-server" "YAML LSP" || ((errors++)) | ||
| verify_command "vscode-json-language-server" "JSON LSP" || ((errors++)) | ||
| verify_command "tsc" "TypeScript Compiler" || ((errors++)) | ||
|
|
||
| echo "" | ||
| if [ $errors -eq 0 ]; then | ||
| echo "=== All Language Servers installed successfully ===" | ||
| else | ||
| echo "=== Warning: $errors language server(s) missing ===" | ||
| fi | ||
|
|
||
| exit 0 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: keito4/config
Length of output: 1061
🌐 Web query:
YAML language identifier LSP language server protocol💡 Result:
Standard LSP language identifier (languageId) for YAML: "yaml". [1]
Common YAML LSP server: Red Hat's yaml-language-server (invoked as the binary
yaml-language-server, client name oftenyamlls), typically started withyaml-language-server --stdio. [2]Sources: [1] Red Hat yaml-language-server README; [2] lsp-mode / nvim-lsp docs.
Change
.ymlextension mapping from"yml"to"yaml".The
.ymlextension currently maps to the language identifier"yml", while.yamlmaps to"yaml". According to LSP standards, the correct language identifier for YAML files is"yaml". Both extensions should map to the same identifier for consistent language server initialization.Current code (lines 37-40)
Change
".yml": "yml"to".yml": "yaml".🤖 Prompt for AI Agents