Skip to content

feat: Update config-base to v1.41.0 - #296

Merged
keito4 merged 1 commit into
mainfrom
update-config-base-1.41.0
Jan 2, 2026
Merged

feat: Update config-base to v1.41.0#296
keito4 merged 1 commit into
mainfrom
update-config-base-1.41.0

Conversation

@keito4

@keito4 keito4 commented Jan 2, 2026

Copy link
Copy Markdown
Owner

Summary

Updates DevContainer configuration to use the latest config-base image and syncs with recommended settings.

Changes

Image Version

  • Image: ghcr.io/keito4/config-base:1.23.0 → v1.41.0

Mounts

  • 📁 Changed: .claude.json (file) → .claude (directory)
    • Claude Code now uses directory mount for full compatibility

Configuration

  • setup-claude.sh: Already included in postCreateCommand
  • .codex mount: Already configured

Claude Code Compatibility

This update ensures full Claude Code compatibility with:

  • Required directory mount for .claude (changed from file mount)
  • Existing .codex mount preserved
  • Automatic Claude CLI setup via setup-claude.sh

Release Notes

See: https://github.com/keito4/config/releases/tag/v1.41.0

Testing Checklist

  • DevContainer builds successfully
  • Claude Code works (can run claude commands)
  • All project-specific tools work as expected
  • CI passes

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Upgraded development container base image to the latest version for improved tooling support and system compatibility.
    • Updated development environment configuration paths to reflect changes in how configuration files are managed.

✏️ Tip: You can customize this high-level summary in your review settings.

- Update DevContainer image from v1.23.0 to v1.41.0
- Change .claude.json file mount to .claude directory mount
- Ensure Claude Code compatibility with directory mount

Release notes: https://github.com/keito4/config/releases/tag/v1.41.0

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jan 2, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Updated the development container configuration: bumped the base image version from 1.23.0 to 1.41.0 and changed the Claude configuration mount source from a single file (~/.claude.json) to a directory (~/.claude).

Changes

Cohort / File(s) Change Summary
DevContainer Configuration
.devcontainer/devcontainer.json
Base image version upgraded from ghcr.io/keito4/config-base:1.23.0 to ghcr.io/keito4/config-base:1.41.0; Claude config bind mount source changed from ~/.claude.json to ~/.claude directory

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

released

Poem

🐰 A devcontainer hops along with glee,
From version one-two-three to one-four-one so free,
The Claude now lives in directories wide,
Instead of a single file—what a joyride! ✨

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the config-base container image version from 1.23.0 to 1.41.0, which is the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bda5a5e and 979d505.

📒 Files selected for processing (1)
  • .devcontainer/devcontainer.json
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: keito4/config PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-01T03:45:17.253Z
Learning: Publish DevContainer images to ghcr.io/keito4/config-base with semantic versioning
Learnt from: CR
Repo: keito4/config PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-01T03:45:17.253Z
Learning: Applies to .github/workflows/docker-image.yml : Build DevContainer images automatically with semantic versioning and multi-platform support in .github/workflows/docker-image.yml
📚 Learning: 2025-12-01T03:45:17.253Z
Learnt from: CR
Repo: keito4/config PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-01T03:45:17.253Z
Learning: Publish DevContainer images to ghcr.io/keito4/config-base with semantic versioning

Applied to files:

  • .devcontainer/devcontainer.json
📚 Learning: 2025-12-01T03:45:17.253Z
Learnt from: CR
Repo: keito4/config PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-01T03:45:17.253Z
Learning: Applies to .github/workflows/docker-image.yml : Build DevContainer images automatically with semantic versioning and multi-platform support in .github/workflows/docker-image.yml

Applied to files:

  • .devcontainer/devcontainer.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: claude-review
  • GitHub Check: Trivy Container Scan
  • GitHub Check: Generate SBOM
🔇 Additional comments (2)
.devcontainer/devcontainer.json (2)

3-3: Version update follows the documented semantic-release strategy and is appropriate.

The jump from 1.23.0 to 1.41.0 represents 18 minor version bumps accumulated from feat: commits since the last release, which is expected behavior per .devcontainer/VERSIONING.md. The commit message (feat: Update config-base image to v1.41.0) contains no BREAKING CHANGE: indication or feat!: syntax, so no breaking changes are expected. The image is automatically built and published to ghcr.io/keito4/config-base:1.41.0 by the GitHub Actions workflow.


38-38: Mount change from file to directory is correct.

The change to mount .claude as a directory is consistent with:

  • The initializeCommand on line 36 that creates the ~/.claude directory
  • The TMPDIR environment variable on line 32 that references /home/vscode/.claude/tmp

This aligns with Claude Code's expected devcontainer configuration and improves consistency between host and container configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

PR レビュー結果

📋 概要

DevContainer設定を最新のconfig-baseイメージ (v1.41.0) に更新し、Claude Code互換性を向上させる変更です。


✅ 良い点

  1. 適切なコミットタイプ: feat: タイプを使用しており、.devcontainer/devcontainer.json の変更に対する要件(CLAUDE.md line 12)を満たしています
  2. セマンティックバージョニング遵守: 1.23.0 → 1.41.0 へのメジャーバージョンアップは、.devcontainer/VERSIONING.md の方針に従っています
  3. 後方互換性のある変更: .claude.json (file) → .claude (directory) への変更は、Claude Codeの最新要件に合致
  4. 適切なPRサイズ: 変更ファイル数1、Diff +2/-2 は、PRガード基準(≤400行/≤25ファイル)を満たしています

⚠️ 指摘事項

1. ドキュメント更新の不整合(重要度: 高)

.claude/devcontainer-recommendations.md の更新が必要です:

  • Line 13, 28: 推奨バージョンが 1.13.1 のまま
  • Line 158: サンプルコードも 1.13.1 を参照

推奨アクション:

- "image": "ghcr.io/keito4/config-base:1.13.1"
+ "image": "ghcr.io/keito4/config-base:1.41.0"

.claude/CLAUDE.md も同様に更新が必要です(Line 89):

- またベースはghcr.io/keito4/config-base:1.13.1を使用する。
+ またベースはghcr.io/keito4/config-base:1.41.0を使用する。

これらのドキュメント更新は、Definition of Done の「ドキュメント更新(README / API Spec / ADR)」要件(CLAUDE.md line 82)を満たすために必須です。

2. initializeCommand の整合性確認(重要度: 中)

現在の設定:

"initializeCommand": "mkdir -p ~/.claude ~/.cursor"

.claude をディレクトリとしてマウントする場合、この initializeCommand は適切ですが、以下を確認してください:

  • ✅ ホスト側で ~/.claude ディレクトリが存在しない場合の初回作成
  • ⚠️ 既存の ~/.claude.json ファイルが存在する環境でのマイグレーション手順

推奨アクション: PRのテストチェックリストまたはREADMEに、既存ユーザー向けのマイグレーション手順を追記:

# 既存の .claude.json がある場合のマイグレーション
mkdir -p ~/.claude
mv ~/.claude.json ~/.claude/config.json  # または適切な移行手順

3. テストカバレッジの欠如(重要度: 中)

PRのテストチェックリストが未完了です:

  • DevContainer builds successfully
  • Claude Code works (can run claude commands)
  • All project-specific tools work as expected
  • CI passes

推奨アクション:

  • DevContainerを実際にビルドして動作確認
  • Claude Code CLIの動作確認(claude --versionなど)
  • 変更による既存機能への影響がないことを確認

🔒 セキュリティ

特に懸念なし。機密情報の追加・変更はありません。


⚡ パフォーマンス

ベースイメージのバージョンアップによる影響は、リリースノート(v1.41.0)の確認が必要です。現時点で特定のパフォーマンス懸念は検出されていません。


📊 品質ゲート準拠状況

項目 ステータス 詳細
Conventional Commits feat: タイプで正しい
Diff サイズ 4行(≤400行)
ファイル数 1ファイル(≤25)
ドキュメント更新 .claude/devcontainer-recommendations.md と .claude/CLAUDE.md の更新が必要
テスト実行 ⚠️ 実行結果が未報告

🎯 推奨アクション

  1. 必須: .claude/devcontainer-recommendations.md のバージョン参照を 1.41.0 に更新
  2. 必須: .claude/CLAUDE.md のバージョン参照を 1.41.0 に更新
  3. 推奨: 既存ユーザー向けマイグレーション手順をドキュメント化
  4. 推奨: テストチェックリストを完了し、結果をPRコメントに追記

📝 総評

技術的には問題のない変更ですが、ドキュメント更新の完了が Definition of Done を満たすために必要です。上記の修正を適用すれば、マージ可能と判断します。

🤖 Generated with Claude Code

@keito4
keito4 merged commit ec7bc69 into main Jan 2, 2026
14 checks passed
@github-actions

github-actions Bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released リリース済み label Jan 2, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jan 16, 2026
5 tasks
@keito4
keito4 deleted the update-config-base-1.41.0 branch January 29, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released リリース済み

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant