Skip to content

chore: remove unused node build pipeline - #136

Merged
keito4 merged 1 commit into
mainfrom
chore/remove-node-build-scripts
Nov 12, 2025
Merged

chore: remove unused node build pipeline#136
keito4 merged 1 commit into
mainfrom
chore/remove-node-build-scripts

Conversation

@keito4

@keito4 keito4 commented Nov 12, 2025

Copy link
Copy Markdown
Owner

概要

  • Node 製の npm run build / npm run validate エントリポイントと scripts/ 配下の重複ロジックを削除し、lint と Jest に一本化しました
  • CI・update-libraries・DevContainer 設定、README を新しい検証フローに合わせて更新しました
  • Jest の検証項目と refactor tracker を整理し、冗長なチェックと TODO を解消しました

テスト

  • npm run lint
  • npm test

Summary by CodeRabbit

  • Build Process

    • Removed build and validation automation steps from CI workflow.
    • Removed build script from available npm commands.
  • Refactor

    • Simplified development workflow by removing build artifacts generation.
    • Updated library update process to focus on linting and testing verification.
  • Tests

    • Updated test expectations to remove build script requirement.
  • Documentation

    • Updated README to reflect changes to library update procedure.

@coderabbitai

coderabbitai Bot commented Nov 12, 2025

Copy link
Copy Markdown

Walkthrough

This pull request removes the build and validation scripts infrastructure from the repository. Changes include deletion of scripts/build.js and scripts/validate.js, removal of corresponding npm script entries from package.json, removal of build/validate steps from CI workflow, updates to related documentation and shell scripts, and adjustments to test expectations.

Changes

Cohort / File(s) Summary
Build system cleanup
scripts/build.js, scripts/validate.js
Removed entire build utility and configuration validator classes, including all validation methods, orchestration logic, and CLI entry points.
Package configuration
package.json
Removed "build" and "validate" npm script entries.
Workflow updates
.github/workflows/ci.yml
Removed Build and Validate steps from CI pipeline; workflow now runs Install, Lint, Formatting check, and Tests only.
Script updates
script/update-libraries.sh
Replaced final build step with separate lint and test execution; removed npm run build invocation.
Settings and permissions
.devcontainer/claude-settings.json
Removed "Bash(npm run build:*)" permission entry from allow-list.
Documentation
README.md, issues/refactor-decouple-batch-01.md
Updated update-libs script behavior in README; updated Issue 3 status in refactor tracking to mark build/validate removal as completed.
Test expectations
test/config-validation.test.js
Removed requirement that package.json must include a build script.

Sequence Diagram(s)

sequenceDiagram
    participant CI as GitHub Actions<br/>CI Workflow
    participant Steps as Workflow Steps
    
    rect rgb(200, 220, 255)
    Note over CI,Steps: Previous Flow
    CI->>Steps: Install dependencies
    CI->>Steps: Lint
    CI->>Steps: Format check
    CI->>Steps: Tests
    CI->>Steps: Build (REMOVED)
    CI->>Steps: Validate (REMOVED)
    end
    
    rect rgb(220, 255, 220)
    Note over CI,Steps: New Flow
    CI->>Steps: Install dependencies
    CI->>Steps: Lint
    CI->>Steps: Format check
    CI->>Steps: Tests
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • File deletions: Review of scripts/build.js and scripts/validate.js to confirm complete removal and understand the extent of removed functionality (ConfigBuilder and ConfigValidator classes with multiple validation methods and orchestration logic).
  • Consistency across files: Verify that all references to build/validate scripts have been removed from CI workflow, package.json, shell scripts, and devcontainer settings.
  • Test updates: Confirm that test expectations correctly reflect removal of build script requirement while maintaining other validation tests.
  • Documentation accuracy: Ensure README and refactor tracking document accurately reflect the changes to update-libs script behavior.

Possibly related PRs

  • Fix/ci pipeline completeness #111: Directly reverses the introduction of build/validate scripts and ConfigBuilder/ConfigValidator classes; this PR removes the exact same files and exports that PR #111 added.
  • docs: refactorバッチの記録とdevcontainer更新 #135: Both PRs modify issues/refactor-decouple-batch-01.md; PR #135 introduces refactor plans for decoupling validation, while this PR marks that work as completed and removes the build/validate infrastructure.
  • chore: automate library updates #129: Related because script/update-libraries.sh previously called npm run build, which is being removed in this PR; the two PRs directly affect the same script and npm commands.

Poem

🐰 The build and validate have taken their bow,
Their duty complete, they depart now.
Lint and tests remain standing tall,
Simpler workflows serve us all! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of the Node.js-based build pipeline (scripts/build.js and scripts/validate.js) and related npm scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-node-build-scripts

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 178c716 and 4c0419f.

📒 Files selected for processing (9)
  • .devcontainer/claude-settings.json (0 hunks)
  • .github/workflows/ci.yml (0 hunks)
  • README.md (1 hunks)
  • issues/refactor-decouple-batch-01.md (1 hunks)
  • package.json (0 hunks)
  • script/update-libraries.sh (1 hunks)
  • scripts/build.js (0 hunks)
  • scripts/validate.js (0 hunks)
  • test/config-validation.test.js (0 hunks)
💤 Files with no reviewable changes (6)
  • test/config-validation.test.js
  • .github/workflows/ci.yml
  • scripts/validate.js
  • .devcontainer/claude-settings.json
  • scripts/build.js
  • package.json
🔇 Additional comments (3)
script/update-libraries.sh (1)

47-49: Clean consolidation of verification pipeline.

The transition from the removed build step to separate lint/test commands is correct and maintains error propagation via the existing set -euo pipefail at line 3. The log message accurately describes the pipeline.

README.md (1)

87-87: Documentation accurately reflects the new verification flow.

The update correctly describes the complete update library workflow: npm-check-updates → npm install → re-synchronization → lint/tests verification. This is consistent with the implementation in script/update-libraries.sh lines 47–49.

issues/refactor-decouple-batch-01.md (1)

31-35: Issue 3 closure is accurately documented.

The completion status correctly captures the removal of redundant build/validate scripts, provides clear context about the duplication issue, and appropriately closes the work with a note on the follow-up verification approach via Jest and shell scripts.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@keito4 keito4 self-assigned this Nov 12, 2025
@keito4
keito4 merged commit 93187a8 into main Nov 12, 2025
3 checks passed
@keito4
keito4 deleted the chore/remove-node-build-scripts branch January 4, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant