fix: 新規マシンセットアップで踏んだ残りの問題を改善 - #1005
Conversation
npm 11.17 生成の lockfile は peer フラグと optional 依存 (argue-cli) を省略しており、npm 11.6 の npm ci が 「Missing: argue-cli@3.1.0 from lock file」で失敗していた。 npm 11.6 で再生成した上位互換の lockfile は 11.6 / 11.17 の 両方で npm ci が通ることを確認済み。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
macOS 標準の bash 3.2 で source すると typeset -g が 「typeset: -g: invalid option」という分かりにくいエラーで失敗する。 brew bash の導入を促す明示的なメッセージで早期に失敗させる。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
設定インポートの副作用として GitHub の全リポジトリを 無条件に ghq get するのは重すぎるため、明示的な --with-repos フラグを指定した場合のみ実行する。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
macOS の nix 管理 npm は prefix が読み取り専用の Nix store を 指すため npm install -g が失敗する。この環境では CLI ツールを nix/home/packages.nix で管理するため、警告を出してスキップする。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error after 3m 6s —— View job I'll analyze this and get back to you. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01c4415f2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if type gh >/dev/null 2>&1 && type ghq >/dev/null 2>&1; then | ||
| gh api user/repos --paginate | jq -r '.[].ssh_url' | xargs -L1 ghq get |
There was a problem hiding this comment.
When --with-repos is used on a fresh Linux bootstrap, brew/LinuxBrewfile installs gh and ghq but not jq (brew/LinuxBrewfile:32-33), so this guard can pass and the next pipeline aborts under set -o pipefail with jq: command not found. Please include jq in the prerequisite check/install path, otherwise the newly documented opt-in clone mode only works when jq was installed independently.
Useful? React with 👍 / 👎.
| if [[ "$npm_prefix" == /nix/store/* ]]; then | ||
| warning "npm prefix が読み取り専用の Nix store を指しています: ${npm_prefix}" | ||
| warning "この環境では npm グローバルは管理対象外のためスキップします (nix/home/packages.nix を参照)" | ||
| exit 0 |
There was a problem hiding this comment.
When the npm prefix is /nix/store, this exits successfully before installing any of the packages below. The warning says the CLI tools are managed in nix/home/packages.nix, but that file's package list does not include happy, @openai/codex, @google/gemini-cli, or vercel, so a fresh nix-darwin setup can report success while leaving the expected commands unavailable. Please either add the Nix-managed equivalents or fail with instructions for a writable npm prefix instead of silently skipping.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 1.127.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
Summary
PR #1004 の続き。新規マシンセットアップ (oykotnoMacBook-Air) で実際に踏んだ、環境差分による失敗 4 件を改善する。
Why
npm ciで「Missing: argue-cli@3.1.0 from lock file」になり、ローカルの npm バージョン次第でセットアップが壊れるscript/lib/output.shを macOS 標準 bash 3.2 で source するとtypeset: -g: invalid optionという原因の分かりにくいエラーで失敗する（jest 17 件の失敗として表面化）import.shが設定インポートの副作用として GitHub の全リポジトリを無条件に ghq クローンするinstall-npm-globals.shは Nix 管理 npm（prefix が読み取り専用の Nix store）では動作しないWhat
npm ciが通ることを確認）--with-reposオプトインに分離（script/README.md に追記）How to test
npm ciが npm 11.6.2 / 11.17.0 の両方で成功npx jest --runInBand779 件全パスimport.sh --checkの従来動作を維持Checklist
Related
🤖 Generated with Claude Code