Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace get-stdin with native alternative #345

Merged
merged 5 commits into from
Mar 4, 2025
Merged

refactor: replace get-stdin with native alternative #345

merged 5 commits into from
Mar 4, 2025

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Mar 1, 2025

This was mentioned in #296 (comment), but things get much easier now, after we drop support for old versions.

@fisker fisker marked this pull request as draft March 1, 2025 12:52
@fisker
Merge branch 'main' into get-stdin
10c02da 
# Conflicts:
#	package-lock.json
#	package.json
@fisker fisker marked this pull request as ready for review March 4, 2025 14:03
@fisker fisker marked this pull request as draft March 4, 2025 14:05
@fisker fisker marked this pull request as ready for review March 4, 2025 14:44
keithamus
keithamus reviewed Mar 4, 2025
View reviewed changes
Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to drop the get-stdin dependency?

@fisker
Copy link
Collaborator Author

fisker commented Mar 4, 2025

Ah, bad merge.

@fisker
Copy link
Collaborator Author

fisker commented Mar 4, 2025

Good to go.

keithamus
keithamus approved these changes Mar 4, 2025
View reviewed changes
Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithamus keithamus merged commit acd24cf into keithamus:main Mar 4, 2025
2 checks passed
@fisker fisker deleted the get-stdin branch March 4, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @keithamus