Add flag to keep node cordoned for reap failures #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shailshah9
force-pushed
the
feature/ignoreDrainFailure
branch
3 times, most recently
from
3f3e0ab
to
c6b65f7
Compare
Signed-off-by: shailshah9 <[email protected]>
…koproj#59) Signed-off-by: Jonah Back <[email protected]> Signed-off-by: shailshah9 <[email protected]>
shailshah9
force-pushed
the
feature/ignoreDrainFailure
branch
from
c6b65f7
to
ee4431b
Compare
Kyle-Wong
reviewed
Nov 8, 2021
Signed-off-by: shailshah9 <[email protected]>
…shah9/governor into feature/ignoreDrainFailure
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 60.00% 62.52% +2.52%
==========================================
Files 9 9
Lines 1425 1425
==========================================
+ Hits 855 891 +36
+ Misses 476 441 -35
+ Partials 94 93 -1
Continue to review full report at Codecov.
|
Signed-off-by: shailshah9 <[email protected]>
Signed-off-by: shailshah9 <[email protected]>
Signed-off-by: shailshah9 <[email protected]>
Signed-off-by: shailshah9 <[email protected]>
Signed-off-by: shailshah9 <[email protected]>
shaoxt
pushed a commit
to shaoxt/governor
that referenced
this pull request
Dec 21, 2021
Signed-off-by: shaoxt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the node fails to drain or if the node-reaper fails because of Bad PDBs, the new flag ignore-failure would keep the node cordoned so that no new pods are scheduled on the bad node.