Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cosmos #188

Merged
merged 51 commits into from
Dec 3, 2019
Merged

Feature/cosmos #188

merged 51 commits into from
Dec 3, 2019

Conversation

ProofOfKeags
Copy link
Contributor

No description provided.

keepkeyjon
keepkeyjon reviewed Nov 12, 2019
View reviewed changes
lib/firmware/cosmos.c Outdated Show resolved Hide resolved
keepkeyjon
keepkeyjon reviewed Nov 12, 2019
View reviewed changes
lib/firmware/cosmos.c Outdated Show resolved Hide resolved
keepkeyjon
keepkeyjon reviewed Nov 12, 2019
View reviewed changes
lib/firmware/cosmos.c Outdated Show resolved Hide resolved
keepkeyjon
keepkeyjon reviewed Nov 12, 2019
View reviewed changes
lib/firmware/cosmos.c Outdated Show resolved Hide resolved
keepkeyjon
keepkeyjon reviewed Nov 13, 2019
View reviewed changes
lib/firmware/cosmos.c Outdated Show resolved Hide resolved
keepkeyjon
keepkeyjon reviewed Nov 13, 2019
View reviewed changes
lib/firmware/cosmos.c Outdated Show resolved Hide resolved
keepkeyjon
keepkeyjon reviewed Nov 22, 2019
View reviewed changes
lib/firmware/cosmos.c Outdated Show resolved Hide resolved
@keepkeyjon
Copy link
Contributor

I made some changes here that are easier to explain with code than in prose: https://github.com/Start9Labs/keepkey-firmware/pull/2

@keepkeyjon
Copy link
Contributor

@CaptJakk more little things: https://github.com/Start9Labs/keepkey-firmware/pull/3/files

@ProofOfKeags
Merge pull request #3 from keepkey/feature/cosmos
cf06bc4 
Update device-protocol, fix whole_account
@ProofOfKeags
Copy link
Contributor Author

What's the status on this?

@keepkeyjon
Copy link
Contributor

What's the status on this?

Looks generally good. I have a small PR against the python-keepkey changes https://github.com/Start9Labs/python-keepkey/pull/1/files, and after that I need to run the tests and do a few on-chain txs from a real device as sanity check. If that checks out, this should be good to merge.

@ProofOfKeags
Copy link
Contributor Author

I just committed the state clearing and merged the python tests PR.

@ProofOfKeags
Copy link
Contributor Author

just wanted to check in on this. I saw they python and device protocol merges happen. Is there anything left on this besides some device testing on your part?

@keepkeyjon
Copy link
Contributor

Is there anything left on this besides some device testing on your part?

Just testing on my part for now.

keepkeyjon
keepkeyjon approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@keepkeyjon keepkeyjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

https://github.com/keepkey/python-keepkey/pull/81/files

@keepkeyjon keepkeyjon merged commit 91dc4f4 into keepkey:master Dec 3, 2019
@GiMa-Maya GiMa-Maya mentioned this pull request Oct 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keepkeyjon keepkeyjon keepkeyjon approved these changes

@solipsis solipsis Awaiting requested review from solipsis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ProofOfKeags @keepkeyjon @dr-bonez