-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: E2E for prometheus #1325
feat: E2E for prometheus #1325
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Signed-off-by: Matvey Kukuy <[email protected]>
@Matvey-Kuk is it ready to merge? |
…' into Matvey-Kuk/fix-1306
Signed-off-by: Matvey Kukuy <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
+ Coverage 63.12% 67.00% +3.87%
==========================================
Files 103 107 +4
Lines 8058 8419 +361
==========================================
+ Hits 5087 5641 +554
+ Misses 2971 2778 -193 ☔ View full report in Codecov by Sentry. |
@Matvey-Kuk just these 2 little comments and lgtm. I don't think there's any code change in here beside adding more test with, right? |
@talboren it's also fixing small issue in the Prom provider: https://github.com/keephq/keep/pull/1325/files#diff-9842ffc00544a71386d24dbb240a527176ebc341e366dd629dcc29f5e872b7edR167 You are right, tests take longer because I included UI building to the test, otherwise it was not reflecting UI changes. |
…' into Matvey-Kuk/fix-1306
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
E2E tests with prometheus instance.