Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2E for prometheus #1325

Merged
merged 37 commits into from
Jul 10, 2024
Merged

feat: E2E for prometheus #1325

merged 37 commits into from
Jul 10, 2024

Conversation

Matvey-Kuk
Copy link
Contributor

E2E tests with prometheus instance.

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 1:46pm

@shahargl
Copy link
Member

shahargl commented Jul 8, 2024

@Matvey-Kuk is it ready to merge?

@Matvey-Kuk Matvey-Kuk changed the title feat: E2E for prometheus WIP: feat: E2E for prometheus Jul 8, 2024
@Matvey-Kuk Matvey-Kuk changed the title WIP: feat: E2E for prometheus feat: E2E for prometheus Jul 10, 2024
keep/api/routes/preset.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.00%. Comparing base (58d30ad) to head (826adc3).
Report is 31 commits behind head on main.

Files Patch % Lines
keep/api/routes/preset.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
+ Coverage   63.12%   67.00%   +3.87%     
==========================================
  Files         103      107       +4     
  Lines        8058     8419     +361     
==========================================
+ Hits         5087     5641     +554     
+ Misses       2971     2778     -193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

keep/api/routes/preset.py Outdated Show resolved Hide resolved
@talboren
Copy link
Member

@Matvey-Kuk just these 2 little comments and lgtm. I don't think there's any code change in here beside adding more test with, right?
Only thing i'm kinda worried about is that e2e tests now take 9 minutes and it sounds a lot

@Matvey-Kuk
Copy link
Contributor Author

@talboren it's also fixing small issue in the Prom provider: https://github.com/keephq/keep/pull/1325/files#diff-9842ffc00544a71386d24dbb240a527176ebc341e366dd629dcc29f5e872b7edR167

You are right, tests take longer because I included UI building to the test, otherwise it was not reflecting UI changes.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matvey-Kuk Matvey-Kuk merged commit 904638c into main Jul 10, 2024
10 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/fix-1306 branch July 10, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants