Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert async Access Confirm Dialog #8665

Merged

Conversation

varjolintu
Copy link
Member

Reverts #8273 because it clearly does not work properly on every operating system. This feature must be remade.

Fixes #8634.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@varjolintu varjolintu added bug feature: Browser pr: backport pending Pull request yet to be backported to a previous release labels Oct 26, 2022
@varjolintu varjolintu added this to the v2.7.4 milestone Oct 26, 2022
@varjolintu varjolintu force-pushed the fix/revert_async_confirm_dialog branch 2 times, most recently from 765bf3c to 8374bb7 Compare October 26, 2022 08:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 64.39%. Comparing base (69f05d4) to head (dd4c3d5).
Report is 344 commits behind head on develop.

Files with missing lines Patch % Lines
src/browser/BrowserService.cpp 0.00% 47 Missing ⚠️
src/browser/BrowserAction.cpp 0.00% 11 Missing ⚠️
src/browser/BrowserAccessControlDialog.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8665      +/-   ##
===========================================
+ Coverage    64.29%   64.39%   +0.10%     
===========================================
  Files          341      341              
  Lines        44336    44242      -94     
===========================================
- Hits         28503    28488      -15     
+ Misses       15833    15754      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey force-pushed the fix/revert_async_confirm_dialog branch from 8374bb7 to dd4c3d5 Compare October 28, 2022 11:33
@droidmonkey droidmonkey merged commit 37baa6f into keepassxreboot:develop Oct 29, 2022
@varjolintu varjolintu deleted the fix/revert_async_confirm_dialog branch October 29, 2022 11:44
@droidmonkey droidmonkey mentioned this pull request Oct 29, 2022
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Oct 29, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Browser pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrade to 2.7.3 on Linux, cannot connect to browser
4 participants