fix CreateFileMappingA Parameter

[masahide]

The last argument of CreateFileMappingA is of type string.

There was a difference in the original implementation of putty(pageant)'s pageant protocol.

In putty(pageant), the thread ID given to the CreateFileMapping mapName is the string '%08x', but in keepassxc, it was a binary number as the thread ID.

According to the CreateFileMapping documentation, the last argument must be of type string.

Changed the thread ID to be assigned to the map name in CreateFileMapping to be an 8-digit hexadecimal number, the same as putty.

Testing strategy

I built on Windows 10 and verified that adding/deleting keys in pageant works correctly.

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (03f11ce) to head (42f580a).
Report is 347 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8619      +/-   ##
===========================================
+ Coverage    64.26%   64.28%   +0.02%     
===========================================
  Files          341      341              
  Lines        44334    44334              
===========================================
+ Hits         28488    28496       +8     
+ Misses       15846    15838       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[droidmonkey]

Interesting this has been in code for long time and it still worked. Good catch though!