Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of AES KDF transform #7755

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Improve speed of AES KDF transform #7755

merged 1 commit into from
Apr 2, 2022

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested develop branch against 2.6.6 and noticed appreciable difference when KDF set to 5 seconds. 2.6.6 is roughly twice as fast.
Tested this branch against 2.6.6 and the difference is eliminated.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

* Remove parallel left/right block calculations in favor of calculating both blocks simultaneously. This brings the calculation within parity of 2.6.6.
* Fix #7682
@droidmonkey droidmonkey added bug pr: backport pending Pull request yet to be backported to a previous release labels Apr 1, 2022
@droidmonkey droidmonkey added this to the v2.7.1 milestone Apr 1, 2022
@droidmonkey droidmonkey requested a review from phoerious April 1, 2022 11:12
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (aca197a) to head (674e8ad).
Report is 461 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7755      +/-   ##
===========================================
- Coverage    64.31%   64.28%   -0.03%     
===========================================
  Files          339      339              
  Lines        43450    43439      -11     
===========================================
- Hits         27943    27924      -19     
- Misses       15507    15515       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey merged commit 41061cf into develop Apr 2, 2022
@droidmonkey droidmonkey deleted the hotfix/aeskdf branch April 2, 2022 16:50
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Apr 6, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Update, it's taking 3x as long to decrypt database.
3 participants