Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: Hide password before unlocking database #7725

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

phoerious
Copy link
Member

Regression introduced in 2.7.

Fixes #7724.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@phoerious phoerious added bug high priority 🚨 security pr: backport pending Pull request yet to be backported to a previous release labels Mar 29, 2022
@phoerious phoerious added this to the v2.7.1 milestone Mar 29, 2022
@phoerious phoerious requested a review from droidmonkey March 29, 2022 19:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.27%. Comparing base (ad61d71) to head (a41b034).
Report is 466 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7725   +/-   ##
========================================
  Coverage    64.27%   64.27%           
========================================
  Files          340      340           
  Lines        43470    43475    +5     
========================================
+ Hits         27936    27941    +5     
  Misses       15534    15534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey
Copy link
Member

Can we also make sure we clear any existing quick unlock settings for the file when the tab is closed?

@phoerious
Copy link
Member Author

I added a commit which does that, but I can't really test it here. Maybe you can.

@droidmonkey droidmonkey merged commit 5c45cf2 into develop Mar 30, 2022
@droidmonkey droidmonkey deleted the fix/hide-password-unlock branch March 30, 2022 03:17
@droidmonkey droidmonkey added pr: backported Pull request backported to previous release and removed pr: backport pending Pull request yet to be backported to a previous release labels Apr 6, 2022
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority 🚨 pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug regression security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master password is not hidden when clicking unlock button (Regression)
3 participants