Make selected text copyable instead of copying password (fix for #7059) #7209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7059. Checks whether the fingerprint, comment, or public key widgets of the SSH Agent tab in the Edit Entry screen are selected when a copy event occurs. If they are, the relevant selected text is copied, otherwise falls back to the current behavior of copying the password. The clipboard is cleared after the timeout if the usual setting is enabled. Below is a short video demonstration of the new behavior. Previously, none of the text mentioned above could be copied using the copy shortcut. The password would be copied instead.
Screenshots
demo.mp4
Testing strategy
I tested the change manually, as you can see in the video included above. I also ran
make test
locally and got the same results on my branch as the develop branch.Type of change