Auto-Type: PageUp/PageDown scrolling for entries #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this code could be as simple as: |
hifi
force-pushed
the
fix/autotype-dialog-paging
branch
from
25d456f to
af7353c
Compare
|
Indeed, it was completely unnecessary to do it with a loop when we know the bounds. Now with net code reduction of 6 lines 🎉 |
hifi
force-pushed
the
fix/autotype-dialog-paging
branch
from
af7353c to
1b446bc
Compare
droidmonkey
force-pushed
the
fix/autotype-dialog-paging
branch
from
13c8039 to
3f00d15
Compare
droidmonkey
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue was likely related to subtle keyboard focus issues in the old dialog but since we explicitly focus in the new input field we can capture these keys in addition to arrows to emulate paging consistently on all platforms. We can't capture Home/End keys because it would conflict with line editing.
Number 5 was chosen by fair dice roll.
Fixes #4530
Testing strategy
Manually on Linux.
Type of change