Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display number of characters in passphrases #5449

Conversation

Colfenor
Copy link
Contributor

@Colfenor Colfenor commented Sep 19, 2020

Fixes #5396

A new information field is added to the passphrase generator view
and depicts the number of characters in the generated passphrase.

Considering the UI-Implementation I'd be happy to hear improvement suggestions
since I'm still a Qt novice.

In the current implementation a character is only counted if it is a number or letter.

So e.g. whitespace or special characters like '&' are not counted. (see attached screenshot)
If this is not the desired behaviour, I'll change it according to the discussion.

Screenshots

Testing strategy

Type of change

  • ✅ New feature (change that adds functionality)

@Colfenor Colfenor changed the title Feature/show number of chars in passphrases Add display number of characters in passphrases Sep 19, 2020
@droidmonkey
Copy link
Member

Why not just pull the length of the text edit field?

@Colfenor
Copy link
Contributor Author

Colfenor commented Sep 19, 2020

alright, so whitespaces and special characters should be counted aswell ?

@droidmonkey
Copy link
Member

droidmonkey commented Sep 19, 2020

Yes absolutely that's part of the length. Or just use password.length()

@Colfenor
Copy link
Contributor Author

Colfenor commented Sep 19, 2020

Yes absolutely that's part of the length. Or just use password.length()

Ok thanks for the clarification ! I had password.size() originally in my first commit, however I somehow thought that whitespace or seperator characters are not needed in the passphrase length.

I changed it now, however on first opening of the password generator widget window, there is an UI bug now where the new QLabel appears to be way off its original position. (I'll dive into it)

@droidmonkey
Copy link
Member

I fixed your layout problem

@droidmonkey droidmonkey added this to the v2.7.0 milestone Sep 21, 2020
@droidmonkey droidmonkey merged commit ac5c1af into keepassxreboot:develop Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Display number of characters in generated passphrases
2 participants