-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display number of characters in passphrases #5449
Add display number of characters in passphrases #5449
Conversation
Why not just pull the length of the text edit field? |
alright, so whitespaces and special characters should be counted aswell ? |
Yes absolutely that's part of the length. Or just use |
Ok thanks for the clarification ! I had I changed it now, however on first opening of the password generator widget window, there is an UI bug now where the new QLabel appears to be way off its original position. (I'll dive into it) |
I fixed your layout problem |
Fixes #5396
A new information field is added to the passphrase generator view
and depicts the number of characters in the generated passphrase.
Considering the UI-Implementation I'd be happy to hear improvement suggestions
since I'm still a Qt novice.
In the current implementation a character is only counted if it is a number or letter.
So e.g. whitespace or special characters like '&' are not counted. (see attached screenshot)
If this is not the desired behaviour, I'll change it according to the discussion.
Screenshots
Testing strategy
Type of change