Add show/hide expired entries on global AutoType #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
requested changes
Aug 28, 2020
* Add setting to hide expired entries from Auto-Type * Expired entries will not be shown in selection dialogs or be auto-picked for use * Fixes keepassxreboot#1855
droidmonkey
force-pushed
the
feature/toggle-expired-entries-on-AutoType
branch
from
6f9da0c to
8ca6ab1
Compare
droidmonkey
approved these changes
Aug 29, 2020
|
Cleaned up the commits and code a little. Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1855
A new checkbox is introduced in the Settings -> General -> Auto-Type - section
named 'Hide expired entries on selecting multiple for global Auto-Type'.
When checked, on hitting the autoType-hotkey and entering the selection screen of multiple entries for the autoType feature, expired entries will not be shown to the user.
If unchecked both expired and valid entries will be shown.
Considering unit-testing, would you like to have a test which ensures the removal of expired entries in the internal matchList ?
Screenshots
Testing strategy
(match URL & Entry Title on global AutoType checkboxes were enabled)
Multiple entries with the same title were created and some were set to expired.
The total count of the valid/expired entries was recorded and compared to the count
if valid/expired items in the AutoTypeSelectDialog screen depending of the checkBox
state set/unset.
Type of change