TOTP Setup Fixes #3622
Merged
TOTP Setup Fixes #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh great! Now we can specify the algorithm for TOTP! This makes SHA-512 TOTP way simpler. Thank you! I can't wait for a release version that includes this nice feature! |
droidmonkey
force-pushed
the
fix/totp-setup
branch
from
f0e755d to
a2632c5
Compare
phoerious
requested changes
Oct 14, 2019
droidmonkey
force-pushed
the
fix/totp-setup
branch
2 times, most recently
from
c6ea68e to
af77955
Compare
droidmonkey
force-pushed
the
fix/totp-setup
branch
from
af77955 to
f1e3117
Compare
* Fix #3142 - Warn user when entering invalid TOTP secret key. * Fix #773 - The TOTP dialog now listens for the copy shortcut without having to press the Copy button. * Add ability to choose hash algorithm from the TOTP setup dialog * Add upgrade to "otp" attribute when custom attributes are chosen to prevent data loss Ran make format
droidmonkey
force-pushed
the
fix/totp-setup
branch
from
f1e3117 to
6baa775
Compare
|
Final changes made |
phoerious
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
Fix TOTP: OTP settings not updated if in invalid format [DATA LOSS] #3142 - Warn user when entering invalid TOTP secret key.
Fix Copy TOTP passwords by pressing CMD+c when it's visible #773 - The TOTP dialog now listens for the copy shortcut without having to press the Copy button.
Add ability to choose hash algorithm from the TOTP setup dialog
Add upgrade to "otp" attribute when custom attributes are chosen to prevent data loss
Screenshots
Testing strategy
Manual and unit testing
Checklist:
-DWITH_ASAN=ON. [REQUIRED]