Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible crash with latest STDIN changes. #1923

Merged
merged 1 commit into from
May 9, 2018
Merged

Fix possible crash with latest STDIN changes. #1923

merged 1 commit into from
May 9, 2018

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented May 9, 2018 •
edited
Loading

QSocketNotifier can be nullptr and it's not checked. Applies to 2.3.2.

Motivation and context

Fixes #1922.

How has this been tested?

Manually.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@phoerious phoerious added this to the v2.3.3 milestone May 9, 2018
@phoerious phoerious added the bug label May 9, 2018
@varjolintu varjolintu changed the base branch from develop to release/2.3.3 May 9, 2018 08:55
@varjolintu varjolintu force-pushed the browser_null_check branch from 86c897e to 34530cc Compare May 9, 2018 09:00
@phoerious phoerious merged commit 3d3bc7a into keepassxreboot:release/2.3.3 May 9, 2018
@varjolintu varjolintu deleted the browser_null_check branch May 9, 2018 09:16
phoerious added a commit that referenced this pull request May 9, 2018
@phoerious
Release 2.3.3
0a155d8 
- Fix crash when browser integration is enabled [#1923]
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoerious phoerious phoerious approved these changes

@weslly weslly Awaiting requested review from weslly

@TheZ3ro TheZ3ro Awaiting requested review from TheZ3ro

@droidmonkey droidmonkey Awaiting requested review from droidmonkey

Assignees
No one assigned
Labels
feature: Browser high priority 🚨 pr: bugfix Pull request that fixes a bug
Projects
None yet
Milestone
v2.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@varjolintu @phoerious