Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Dockerfile to run keepassxc in a container #190

Closed
wants to merge 1 commit into from
Closed

Adding a Dockerfile to run keepassxc in a container #190

wants to merge 1 commit into from

Conversation

auzias
Copy link

@auzias auzias commented Jan 24, 2017

Description

The file Docker/Dockerfile can be used to build a Docker image.
To build the image and run a container see the file Docker/README.md.

Motivation and Context

This change is required in order to provide a community manage Docker image.

How Has This Been Tested?

The container has been tested using the commands shown in Docker/README.md.

Types of changes

  • ✅ New feature (non-breaking change which adds functionality)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]

The file `Docker/Dockerfile` can be used to build a Docker image.
To build the image and run a container see the file `Docker/README.md`.
@phoerious
Copy link
Member

phoerious commented Jan 24, 2017

I would prefer distributing only stable and signed releases as Docker images, not the current develop branch.

For building KeePassXC in a Docker container, we already have a Docker image based on Ubuntu 16.04. However, this still needs some work and we probably need to go back to CentOS 6.8 for best compatibility across the Linux landscape.

Also one issue we have when running KeePassXC inside a Docker container is that the UID inside the container must match the UID of the host if you don't want to run KeePassXC as root inside the container. Otherwise you can't write to the database file.

droidmonkey pushed a commit that referenced this pull request Jan 28, 2017
* Search Group details in addition to entry details; feature parity with KeePass
* Remove assertions to prevent crashes in Debug mode when search result is empty
@droidmonkey
Copy link
Member

Is this still required now that we have a docker container as part of the release script?

@phoerious
Copy link
Member

I think this one is more intended to actually run KeePassXC. I'm not quite sure, though, where to put it in the source tree and how to properly distribute it.

@auzias
Copy link
Author

auzias commented Feb 10, 2017

It is indeed to run KeePassXC, not compile it. As for!

@phoerious
Copy link
Member

phoerious commented Mar 2, 2017

After some more consideration, I still don't know where to put this. I would prefer having this Dockerfile on Dockerhub instead of our repository. I think that would be a better place.
We already have a Snap package which does about the same as a Docker container, only better.

@droidmonkey
Copy link
Member

Recommend moving this to the packaging repo.

@droidmonkey
Copy link
Member

Migrated over to keepassxc-packaging/#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants