Add \n in merge request message. #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weslly
approved these changes
Dec 20, 2017
TheZ3ro
approved these changes
Dec 20, 2017
phoerious
reviewed
Dec 22, 2017
| @@ -1247,7 +1247,7 @@ void DatabaseWidget::reloadDatabaseFile() | |||
| if (m_databaseModified) { | |||
| // Ask if we want to merge changes into new database | |||
| QMessageBox::StandardButton mb = MessageBox::question(this, tr("Merge Request"), | |||
| tr("The database file has changed and you have unsaved changes." | |||
| tr("The database file has changed and you have unsaved changes.\n" | |||
There was a problem hiding this comment.
Please use append(). Newlines don't need to be translated and including it in the translation source string breaks existing translations.
|
Wait, what... Didn't see this was merged already. Can we please get a follow-up for for this? EDIT: actually, forget what I said. It's in the middle of the string. No way to add it without breaking translations. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this while testing #1231
How has this been tested?
Locally
Screenshots (if appropriate):
before:
after:
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]