Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry preview rendering HTML #11539

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Fix entry preview rendering HTML #11539

merged 1 commit into from
Dec 24, 2024

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Dec 7, 2024

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

* Fixes #11538 - prevent rendering HTML in Title, Password, and URL fields in the entry preview pane.
@droidmonkey droidmonkey added user interface pr: bugfix Pull request that fixes a bug labels Dec 7, 2024
@droidmonkey droidmonkey added this to the v2.7.10 milestone Dec 7, 2024
@droidmonkey droidmonkey requested a review from phoerious December 7, 2024 15:48
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.91%. Comparing base (b1180b3) to head (7b70cc9).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/EntryPreviewWidget.cpp 66.67% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11539      +/-   ##
===========================================
+ Coverage    63.91%   63.91%   +0.01%     
===========================================
  Files          362      362              
  Lines        38147    38147              
===========================================
+ Hits         24378    24381       +3     
+ Misses       13769    13766       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey droidmonkey merged commit 5e61db6 into develop Dec 24, 2024
11 checks passed
@droidmonkey droidmonkey deleted the fix/preview-html branch December 24, 2024 13:25
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich text markup in password is interpreted in preview pane
2 participants