Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestGui: testTotp: use QTRY_COMPARE #10901

Merged
merged 1 commit into from
Jun 14, 2024
Merged

TestGui: testTotp: use QTRY_COMPARE #10901

merged 1 commit into from
Jun 14, 2024

Conversation

c4rlo
Copy link
Contributor

@c4rlo c4rlo commented Jun 14, 2024

A check in TestGui::testTotp failed in #10853, presumably because of inherent raciness:

20:28:37   FAIL!  : TestGui::testTotp() Compared values are not the same
20:28:37      Actual   (totpLabel->text().replace(" ", "")): "625751"
20:28:37      Expected (entry->totp())                     : "067152"
20:28:37      Loc: [/Users/KPXC/buildAgent/work/c401303cba1b4098/tests/gui/TestGui.cpp(1033)]

Paper over the raciness by using QTRY_COMPARE instead of QCOMPARE.

@c4rlo c4rlo mentioned this pull request Jun 14, 2024
Merged
@droidmonkey droidmonkey merged commit af2ba79 into keepassxreboot:develop Jun 14, 2024
11 checks passed
@droidmonkey droidmonkey added the pr: tests Pull requests that adds or modifies tests label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees
No one assigned
Labels
pr: tests Pull requests that adds or modifies tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c4rlo @droidmonkey