Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct QuickUnlock without prompting user to confirm unlocking attempt #9030

Closed
zavjah opened this issue Jan 26, 2023 · 12 comments · Fixed by #9697
Closed

Direct QuickUnlock without prompting user to confirm unlocking attempt #9030

zavjah opened this issue Jan 26, 2023 · 12 comments · Fixed by #9697

Comments

@zavjah
Copy link

zavjah commented Jan 26, 2023

As discussed with @phoerious and @droidmonkey in #keepassxc:mozilla.org today, I'd like to be directly prompted for my fingerprint when QuickUnlock is enabled and the application get the focus after the first lock.

As of now, once the user has unlocked the DB for the first time and has enabled QuickUnlock, every time the app is locked and is back in focus because the user wants to use it, user first must confirm that he/she want's to actually unlock before QuickUnlock modal is shown.

image

As most users will activate the application for exactly that reason rather than by accident, it should be either the standard behavior or at least an option for user to select that QuickUnlock is automatically triggered. In case the application is in focus by accident, user can still abort the QuickUnlock and thus return to the main screen. Even with more than one DB open, this could be applied for the last open DB ignoring all other open DBs.

@droidmonkey droidmonkey self-assigned this Jan 26, 2023
@droidmonkey droidmonkey added this to the v2.7.5 milestone Jan 26, 2023
@zavjah
Copy link
Author

zavjah commented May 17, 2023

Hello @droidmonkey, release 2.7.5 is out and this feature seems not to be in it. Is that correct?

Thx and cheers,
Zavjah

@droidmonkey
Copy link
Member

droidmonkey commented May 17, 2023

The request is still open, we ended up not working on this one.

@foss-
Copy link

foss- commented Jun 15, 2023

KeePassXC unlock dialog, which would be great to show right away (currently requires a press of a button to be opened):
KeePassXC unlock dialog

1Password unlock dialog with option to enter Password:
1P unlock dialog

Three things are interesting about the 1Password implementation:

  1. their unlock dialog opens in active state right away, which makes a more seamless workflow
  2. the unlock dialog allows, to switch to password
  3. the wording in the dialog is less technical and more approachable

@droidmonkey droidmonkey modified the milestones: v2.7.5, v2.7.6 Jun 16, 2023
droidmonkey added a commit that referenced this issue Aug 6, 2023
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.
droidmonkey added a commit that referenced this issue Aug 6, 2023
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue.

* Disable quick unlock in gui tests
droidmonkey added a commit that referenced this issue Aug 6, 2023
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
droidmonkey added a commit that referenced this issue Aug 6, 2023
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
droidmonkey added a commit that referenced this issue Aug 10, 2023
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
@zavjah
Copy link
Author

zavjah commented Aug 10, 2023

AWESOME, thank you :-D

@phoerious
Copy link
Member

This is only for the modal dialog at this point, not the main window.

@zavjah
Copy link
Author

zavjah commented Aug 10, 2023

This is only for the modal dialog at this point, not the main window.

What exactly is the modal?

@phoerious
Copy link
Member

Mostly when you unlock your DB from the browser extension.

@zavjah
Copy link
Author

zavjah commented Aug 10, 2023

OK, never using this. I was referring to the main window than, as stated in my initial post.

Why is my suggestion closed, when what I requested is not implemented? or will it come, too, in next release?

@droidmonkey
Copy link
Member

droidmonkey commented Aug 10, 2023

We will consider implementing it in a future version, but this is closed because we have implemented what we want to right now.

@zavjah
Copy link
Author

zavjah commented Aug 11, 2023

Such a pity, I was really looking forward to this. It's quite annoying to must have click on unlock few dozen times a day although it's more than obvious that one wants to use the application 😔

@phoerious
Copy link
Member

Usually, you can also just press enter.

@zavjah
Copy link
Author

zavjah commented Aug 11, 2023

Hello @phoerious , yes, I am aware of that but it doesn't make a great difference, if user must click or press.

droidmonkey added a commit that referenced this issue Aug 14, 2023
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
evur pushed a commit to BrokenMS/keepassxc that referenced this issue Aug 23, 2023
* Fix keepassxreboot#7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix keepassxreboot#9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix keepassxreboot#9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants