Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong plural i18n string in Service.cpp #874

Closed
meskobalazs opened this issue Aug 16, 2017 · 3 comments
Closed

Wrong plural i18n string in Service.cpp #874

meskobalazs opened this issue Aug 16, 2017 · 3 comments

Comments

@meskobalazs
Copy link
Contributor

In the keepassxc/src/http/Service.cpp file, there is this line at 548:

tr("Successfully removed %1 encryption-%2 from KeePassX/Http Settings.").arg(count).arg(count ? "keys" : "key")

The string should use plurals correctly, as right now key or keys are hardcoded. I would do the fix myself, but I don't know Qt.

@phoerious
Copy link
Member

There are more occurrences of problems like this. We need to fix them at some point.

@meskobalazs
Copy link
Contributor Author

I am no expert on either C++ or Qt, but this should fix it.

Noettore added a commit to Noettore/keepassxc that referenced this issue Aug 21, 2017
@weslly
Copy link
Contributor

weslly commented Nov 22, 2017

Fixed at #875

@weslly weslly closed this as completed Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants