Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when closing tab during password processing #7239

Closed
Semnodime opened this issue Dec 21, 2021 · 1 comment · Fixed by #8144
Closed

Crash when closing tab during password processing #7239

Semnodime opened this issue Dec 21, 2021 · 1 comment · Fixed by #8144
Assignees
@droidmonkey
Labels
crash 💥 high priority 🚨
Milestone
v2.7.2

Comments

@Semnodime
Copy link

Overview

KeepassXC crashes when a database tab is closed while it attempts to open it (key derivation function processing in progress).

Steps to Reproduce

  1. Two Database tabs
  2. Enter wrong password into database tab
  3. While password is processed, close tab
  4. Short wait period (till end of key derivation function) ~0.1-2s

Expected Behavior

No crash.

Actual Behavior

Crash. App closes.

KeePassXC - 2.6.6
Revision: unknown

Operating System: Linux Mint 21
Desktop Env: Cinnamon
Windowing System: X11
@Semnodime Semnodime added the bug label Dec 21, 2021
@droidmonkey
Copy link
Member

This is still a problem and made slightly worse with Quick Unlock.

@droidmonkey droidmonkey self-assigned this Mar 21, 2022
@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 21, 2022
@phoerious phoerious modified the milestones: v2.7.1, v2.7.2 Apr 12, 2022
droidmonkey added a commit that referenced this issue Jun 12, 2022
@droidmonkey
Fix crash when trying to close database during unlock
9b92cc8 
* Fix #7239 - prevent closing the database widget if the open dialog is still unlocking the database. This problem became slightly worse with quick unlock.

With this fix, if the user tries to close the database during unlock we will just ignore that request.
@droidmonkey droidmonkey mentioned this issue Jun 12, 2022
Merged
droidmonkey added a commit that referenced this issue Jun 14, 2022
@droidmonkey
Fix crash when trying to close database during unlock
b86c3e6 
* Fix #7239 - prevent closing the database widget if the open dialog is still unlocking the database. This problem became slightly worse with quick unlock.

With this fix, if the user tries to close the database during unlock we will just ignore that request.
droidmonkey added a commit that referenced this issue Jun 27, 2022
@droidmonkey
Fix crash when trying to close database during unlock
b488880 
* Fix #7239 - prevent closing the database widget if the open dialog is still unlocking the database. This problem became slightly worse with quick unlock.

With this fix, if the user tries to close the database during unlock we will just ignore that request.
t-h-e pushed a commit to t-h-e/keepassxc that referenced this issue Sep 8, 2022
@droidmonkey @t-h-e
Fix crash when trying to close database during unlock
9273c31 
* Fix keepassxreboot#7239 - prevent closing the database widget if the open dialog is still unlocking the database. This problem became slightly worse with quick unlock.

With this fix, if the user tries to close the database during unlock we will just ignore that request.
droidmonkey added a commit that referenced this issue Sep 22, 2022
@droidmonkey
Fix crash when trying to close database during unlock
d954519 
* Fix #7239 - prevent closing the database widget if the open dialog is still unlocking the database. This problem became slightly worse with quick unlock.

With this fix, if the user tries to close the database during unlock we will just ignore that request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
crash 💥 high priority 🚨
Projects
None yet
Milestone
v2.7.2
Development

Successfully merging a pull request may close this issue.

Fix crash when trying to close database during unlock keepassxreboot/keepassxc
3 participants
@phoerious @droidmonkey @Semnodime